fix(core): repair malformed runStep, restore tests and config#55
Open
arpit2006 wants to merge 1 commit into
Open
fix(core): repair malformed runStep, restore tests and config#55arpit2006 wants to merge 1 commit into
arpit2006 wants to merge 1 commit into
Conversation
Contributor
Author
|
@NEXARA-oss , Requesting Review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Overview
This Pull Request resolves a TypeScript compilation failure caused by a malformed and duplicated implementation of the
runStepmethod inruntime.ts.The existing code contained overlapping logic between
runStepandrunStepWithRetry, resulting in invalid method signatures, mismatched function bodies, and parser errors that prevented successful project builds. This change restores proper method separation, removes duplicate declarations, and ensures both methods have valid TypeScript syntax and well-defined responsibilities.By correcting the method structure, the runtime execution flow is preserved while restoring build stability and developer productivity.
Related Issues
Architecture and Implementation Details
runStepimplementation to ensure a single valid method declaration.runStepWithRetry.runStepandrunStepWithRetryaccording to their intended responsibilities.Breaking Changes
This change only fixes an invalid implementation and does not modify public APIs, configuration schemas, or runtime behavior.
Testing Methodology
runtime.tsno longer produces syntax or parser errors.runStepandrunStepWithRetryare independently recognized by the TypeScript compiler.Performance & Observability Impact
Contributor Checklist