Skip to content

fix(core): repair malformed runStep, restore tests and config #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
arpit2006 wants to merge 1 commit into
base: main
Choose a base branch
from
+152 −193
Open

fix(core): repair malformed runStep, restore tests and config #55

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions packages/core/src/lib/config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,9 +30,7 @@ const envSchema = z.object({
API_KEY: z.string().default('pulsestack-local-api-key'),
TENANT_ID: z.string().default('local'),
PLUGIN_DIR: z.string().default('./plugins'),
issue-30-auth-disabled-false
AUTH_DISABLED: booleanEnv.default(true),
AUTH_DISABLED: z.coerce.boolean().default(true),
OTEL_TRACING_ENABLED: z.coerce.boolean().default(false),
OTEL_SERVICE_NAME: z.string().default(''),
OTEL_TRACES_EXPORTER: z.enum(['none', 'console']).default('none'),
Expand Down
21 changes: 9 additions & 12 deletions packages/core/src/lib/runtime.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,11 @@

import { describe, expect, it } from 'vitest';
import type { EventEnvelope, WorkflowDefinition } from '@pulsestack/contracts';
import type {
EventEnvelope,
WorkflowDefinition,
ExecutionSnapshot,
TraceSpan,
} from '@pulsestack/contracts';
import type { PulseInfra } from './infra.js';
import { WorkflowRuntime } from './runtime.js';

class RuntimeInfraMock {
Expand Down Expand Up @@ -43,15 +48,8 @@ describe('WorkflowRuntime', () => {
);
expect(tenantEvents.length).toBeGreaterThan(0);
expect(tenantEvents.every((event) => event.tenantId === workflow.tenantId)).toBe(true);

import type {
EventEnvelope,
ExecutionSnapshot,
TraceSpan,
} from '@pulsestack/contracts';
import { describe, expect, it } from 'vitest';
import type { PulseInfra } from './infra.js';
import { WorkflowRuntime } from './runtime.js';
});
});

function createRuntimeHarness() {
const events: EventEnvelope[] = [];
Expand Down Expand Up @@ -198,6 +196,5 @@ describe('WorkflowRuntime retry handling', () => {
'Step fetch_logs failed after 2 attempts: Simulated failure for fetch_logs on attempt 2',
},
});

});
});
Loading