Standardize filter output figures across MOSuite function calls#3
Open
phoman14 wants to merge 10 commits into
Open
Standardize filter output figures across MOSuite function calls#3phoman14 wants to merge 10 commits into
phoman14 wants to merge 10 commits into
Conversation
Add the MOSuite plot color default to filter-counts, pass colors_for_plots through to the package, and document how extra group colors are generated.
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR aligns the filter-counts capsule with the package-level figure standardization work. The intent is for figures produced from this capsule to match figures produced by the corresponding MOSuite function calls, rather than carrying capsule-specific color or legend defaults.
Changes
filter_counts()can use the package's automatic legend text scaling for many or long labels.CHANGELOG.mdfor the user-facing default changes.Validation: local capsule tests passed (
PASS 7).Issues
No linked issue.
PR Checklist
(
Strikethroughany points that are not applicable.)CHANGELOG.mdwith a short description of any user-facing changes and reference the PR number. Follow the style described in https://style.tidyverse.org/news.htmltestsworkflow succeeds on the latest commit.