This repository was archived by the owner on Jul 3, 2023. It is now read-only.
Convert the visual mesh component to use rays instead of pixel coordinates for UVs#267
Draft
TrentHouliston wants to merge 2 commits intomasterfrom
Draft
Convert the visual mesh component to use rays instead of pixel coordinates for UVs#267TrentHouliston wants to merge 2 commits intomasterfrom
TrentHouliston wants to merge 2 commits intomasterfrom
Conversation
Member
Can you provide a description? 😛 I have no idea what this does |
TrentHouliston
force-pushed
the
houliston/vmrays
branch
from
b59fb97 to
d6dad09
Compare
TrentHouliston
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This branch changes how the visual mesh is drawn on images and in the VisualMesh view.
Previously the visual mesh on the robot calculated pixel coordinates that were used to draw on the image.
However, when the rotation of the image changed the visual mesh/image would get out of sync since the visual mesh was using old pixel coordinates.
This change makes the visual mesh instead of send unit vectors in global space. These can then be projected onto the image directly which using the images Hcw matrix will track each other as they move.