Move driver and nvrtc cython and internal layers to new generator by mdboom · Pull Request #1972 · NVIDIA/cuda-python

mdboom · 2026-04-24T13:46:37Z

This is a continuation of the work in #1900. Now adds driver to the mix and both nvrtc and driver are generated from the "real" new generator.

copy-pr-bot · 2026-04-24T13:46:40Z

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

mdboom · 2026-04-24T13:47:21Z

/ok to test

mdboom · 2026-04-24T14:59:54Z

/ok to test

mdboom · 2026-04-24T17:37:15Z

/ok to test

mdboom · 2026-04-24T17:52:22Z

/ok to test

mdboom · 2026-04-24T19:05:25Z

/ok to test

mdboom · 2026-04-24T20:48:19Z

/ok to test

mdboom · 2026-04-24T21:30:36Z

/ok to test

mdboom · 2026-04-25T14:21:56Z

/ok to test

mdboom · 2026-04-25T15:17:05Z

/ok to test

mdboom · 2026-04-25T15:17:34Z

/ok to test

mdboom · 2026-04-29T13:38:07Z

/ok to test

mdboom · 2026-06-10T18:32:37Z

@leofang: This is passing all the tests now. I think this is good to go (and let's merge the generator-side thing at roughly the same time, if we can).

leofang · 2026-06-10T19:02:01Z

It turns out the exception signature needs to match exactly when declaring function pointer types (which cuda-core does in one spot).

I assume that this also helps us avoid any potential (Cython) ABI breakage?

leofang · 2026-06-10T22:13:31Z

I wish we have the ABI test running in the CI 😛 Eyeball'd as much as I can. Thanks, Mike!

The CI flakiness should be fixed in #2195. I retried a few times here to make it green.

leofang

Re-reviewing the symbol-loading rework end-to-end against main. Two file-anchored concerns below, plus one branch-state issue:

Missing CUDA 13.3 symbols. The following are declared and loaded in _bindings/cydriver.pyx.in on main (all at cudaVersion=13030) but absent from every new file in this PR (driver_linux.pyx, driver_windows.pyx, _internal/driver.pxd, cydriver.pyx):

cuLogicalEndpoint{Create,Destroy,AddDevice,BindAddr,BindMem,Unbind,Export,Import,Query,GetLimits,IdRelease,IdReserve} — 12 functions
cuStreamBeginRecaptureToGraph — 1 function

Looks like the branch was regenerated before these landed on main. Calling any of them post-merge would be a hard breakage, so this needs a rebase + regen before going in. Not a design fix.

Cancelling my prior approval until that and the inline comments are addressed.

-- Leo's bot

mdboom · 2026-06-11T13:26:07Z

It turns out the exception signature needs to match exactly when declaring function pointer types (which cuda-core does in one spot).

I assume that this also helps us avoid any potential (Cython) ABI breakage?

It does. It's overly strict (it wouldn't have been a breakage in this specific case), but at least if we /really/ broke it we know Cython would tell us.

mdboom · 2026-06-11T14:28:03Z

@leofang: I have updated this to include the ptds version numbers where appropriate and also added ptds testing to a couple of the configurations in CI.

Co-authored-by: Leo Fang <leof@nvidia.com>

leofang · 2026-06-11T21:48:38Z

@mdboom this regression is not yet addressed?

Missing CUDA 13.3 symbols. The following are declared and loaded in _bindings/cydriver.pyx.in on main (all at cudaVersion=13030) but absent from every new file in this PR (driver_linux.pyx, driver_windows.pyx, _internal/driver.pxd, cydriver.pyx):

cuLogicalEndpoint{Create,Destroy,AddDevice,BindAddr,BindMem,Unbind,Export,Import,Query,GetLimits,IdRelease,IdReserve} — 12 functions

cuStreamBeginRecaptureToGraph — 1 function

mdboom · 2026-06-12T12:25:21Z

@mdboom this regression is not yet addressed?

Missing CUDA 13.3 symbols. The following are declared and loaded in _bindings/cydriver.pyx.in on main (all at cudaVersion=13030) but absent from every new file in this PR (driver_linux.pyx, driver_windows.pyx, _internal/driver.pxd, cydriver.pyx):

cuLogicalEndpoint{Create,Destroy,AddDevice,BindAddr,BindMem,Unbind,Export,Import,Query,GetLimits,IdRelease,IdReserve} — 12 functions

cuStreamBeginRecaptureToGraph — 1 function

Sorry, I didn't see this comment yesterday. These have been added now.

github-actions · 2026-06-13T00:48:24Z

Doc Preview CI
Preview removed because the pull request was closed or merged.

* Move driver and nvrtc cython and internal layers to new generator (#1972) * Move driver and nvrtc cython and internal layers to new generator * Fix Cython interop tests * Handle headers differently * Fix compilation * Make const match * Fix compilation again * Attempt to fix Windows build * Fix Windows again * Fix not found error code * Look up pointers in a different way * Get first version right * Get first appearing versions correct * Fix weird special case * Fix exception signature to match what was there before * Also fix exception declaration in nvrtc * Fix PTDS and add PTDS testing * Update .gitignore Co-authored-by: Leo Fang <leof@nvidia.com> --------- Co-authored-by: Leo Fang <leof@nvidia.com> * Fix up generated code * Correctly set CUDA_VERSION --------- Co-authored-by: Leo Fang <leof@nvidia.com>

Move driver and nvrtc cython and internal layers to new generator

f842321

github-actions Bot added the cuda.bindings Everything related to the cuda.bindings module label Apr 24, 2026

Fix Cython interop tests

992998a

Handle headers differently

6b1d2d3

Fix compilation

be5d972

github-actions Bot added CI/CD CI/CD infrastructure cuda.core Everything related to the cuda.core module labels Apr 24, 2026

mdboom force-pushed the driver-v2 branch from cbf9660 to be5d972 Compare April 24, 2026 19:26

Make const match

2d7c8dd

Fix compilation again

f664c86

This comment has been minimized.

Sign in to view

leofang assigned mdboom Apr 24, 2026

leofang self-requested a review April 24, 2026 23:59

leofang added this to the cuda.bindings 13.3.0 & 12.9.7 milestone Apr 24, 2026

Attempt to fix Windows build

00ea580

Fix Windows again

9982e06

Fix not found error code

6bf0565

Merge remote-tracking branch 'upstream/main' into driver-v2

103c29f

mdboom added 2 commits June 10, 2026 11:22

Merge branch 'main' into driver-v2

2275890

Merge branch 'main' into driver-v2

186c394

mdboom requested a review from leofang June 10, 2026 18:32

leofang approved these changes Jun 10, 2026

View reviewed changes

leofang requested changes Jun 11, 2026

View reviewed changes

Comment thread cuda_bindings/cuda/bindings/_internal/driver_linux.pyx Outdated

Comment thread cuda_bindings/cuda/bindings/_internal/driver_linux.pyx Outdated

Merge branch 'main' into driver-v2

0155f57

Fix PTDS and add PTDS testing

7dbeaa0

github-actions Bot added the CI/CD CI/CD infrastructure label Jun 11, 2026

mdboom and others added 3 commits June 11, 2026 13:04

Update .gitignore

3aec179

Co-authored-by: Leo Fang <leof@nvidia.com>

Merge branch 'main' into driver-v2

0a1a49d

Merge branch 'main' into driver-v2

c294d66

mdboom requested a review from leofang June 11, 2026 20:40

mdboom enabled auto-merge (squash) June 11, 2026 20:47

mdboom added 2 commits June 12, 2026 08:24

Add missing 13.3 APIs

13f5106

Merge remote-tracking branch 'origin/driver-v2' into driver-v2

1a87ff3

Correctly update all files

836d5a9

leofang approved these changes Jun 12, 2026

View reviewed changes

mdboom merged commit c128381 into NVIDIA:main Jun 12, 2026
200 of 202 checks passed

This comment has been minimized.

Sign in to view

mdboom mentioned this pull request Jun 12, 2026

Catch up with recent cybind changes #2205

Draft

leofang mentioned this pull request Jun 15, 2026

Backport #1972 to 12.9.x #2206

Merged

Conversation

mdboom commented Apr 24, 2026

Uh oh!

copy-pr-bot Bot commented Apr 24, 2026

Uh oh!

mdboom commented Apr 24, 2026

Uh oh!

mdboom commented Apr 24, 2026

Uh oh!

mdboom commented Apr 24, 2026

Uh oh!

mdboom commented Apr 24, 2026

Uh oh!

mdboom commented Apr 24, 2026

Uh oh!

mdboom commented Apr 24, 2026

Uh oh!

mdboom commented Apr 24, 2026

Uh oh!

This comment has been minimized.

mdboom commented Apr 25, 2026

Uh oh!

mdboom commented Apr 25, 2026

Uh oh!

mdboom commented Apr 25, 2026

Uh oh!

mdboom commented Apr 29, 2026

Uh oh!

mdboom commented Jun 10, 2026

Uh oh!

leofang commented Jun 10, 2026

Uh oh!

leofang commented Jun 10, 2026

Uh oh!

leofang left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

mdboom commented Jun 11, 2026

Uh oh!

mdboom commented Jun 11, 2026

Uh oh!

leofang commented Jun 11, 2026

Uh oh!

mdboom commented Jun 12, 2026

Uh oh!

Uh oh!

This comment has been minimized.

github-actions Bot commented Jun 13, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants