Use pybind11-stubgen to create typestubs for extensions#87
Draft
jbcoe wants to merge 31 commits intoNetHack-LE:mainfrom
Draft
Use pybind11-stubgen to create typestubs for extensions#87jbcoe wants to merge 31 commits intoNetHack-LE:mainfrom
jbcoe wants to merge 31 commits intoNetHack-LE:mainfrom
Conversation
jbcoe
force-pushed
the
jbcoe/generate-typestubs
branch
from
9b6791d to
4414e0f
Compare
jbcoe
force-pushed
the
jbcoe/generate-typestubs
branch
2 times, most recently
from
02e76e3 to
4a2f8cd
Compare
…include numpy and pybind11_stubgen
jbcoe
force-pushed
the
jbcoe/generate-typestubs
branch
from
564345c to
ecde6bb
Compare
This reverts commit 1d2bd70.
jbcoe
force-pushed
the
jbcoe/generate-typestubs
branch
from
2495a9b to
98a723d
Compare
… as a COMMAND, CMake resolves it to the actual executable at build time via the target machinery, not by embedding a string path at configure time. This is the distinction: a target reference stays late-bound, a variable like ${Python_EXECUTABLE} gets expanded to a string immediately at configure time and baked into build.ninja.
Collaborator
Author
|
This is interacting poorly with the fast editable build I set up. I'm reluctant to use --no-build-isolation as suggested in https://scikit-build-core.readthedocs.io/en/stable/configuration/#editable-installs I'll think about how we might make progress. Faster rebuilds seem useful as do typestubs. |
This reverts commit 0b96483. Fast rebuilds with uv and scikit-build and use of Python tooling within a CMake build are incompatible. The isolated environment used for the build means that the Python executable cached in the build directory is not valid when the build directory is used for a rebuild.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generated typestubs will allow us to give richer type information and enable a type-checker as part of our CI workflow.
I've created a custom action to generate the typestubs. A newer bindings generator link nanobind already exposes CMake rules to generate typestubs.
Needs (sadly) #108 to be merged first.