This repository was archived by the owner on Dec 13, 2023. It is now read-only.
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #972 +/- ##
============================================
+ Coverage 62.07% 62.22% +0.14%
- Complexity 2548 2556 +8
============================================
Files 225 225
Lines 12885 12888 +3
Branches 1280 1281 +1
============================================
+ Hits 7999 8019 +20
+ Misses 4177 4159 -18
- Partials 709 710 +1
Continue to review full report at Codecov.
|
Pull Request Test Coverage Report for Build 2347
💛 - Coveralls |
76b46d7 to
a1561f9
Compare
kishorebanala
approved these changes
Feb 5, 2019
Contributor
|
@davidwadden Looks good. Would you mind fixing the codecov checks please, so that I can go ahead and merge. Current set-up doesn't allow me to merge. |
Collaborator
|
@davidwadden Thanks for your contribution. |
+ Upgrades dyno-queues to v2.0.0-rc5 Signed-off-by: Carlton Schuyler <cschuyler@pivotal.io>
a1561f9 to
a24b7c8
Compare
Closed
long-64
pushed a commit
to long-64/conductor
that referenced
this pull request
Oct 2, 2019
Redis Authentication Support
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates Conductor to use changes in the
dynolibrary to connect to Redis instances requiring password authentication. It does so by parsing an optional 4th colon-delimited string fromworkflow.dynomite.cluster.hoststo set the password on the underlyingJedisclient. (shown below)I'm looking for any feedback to support getting this change merged.
See Netflix/dyno#244 for the underlying changes, included as transitive dependency with
dyno-queues:2.0.0-rc5upgrade.https://github.com/Netflix/dyno/blob/v1.6.5/dyno-jedis/src/main/java/com/netflix/dyno/jedis/JedisConnectionFactory.java#L80-L93