Merged
Conversation
Closed
james7132
reviewed
Aug 20, 2025
75e179b to
ee9a95b
Compare
ee9a95b to
e607d29
Compare
hymm
reviewed
Aug 21, 2025
hymm
left a comment
There was a problem hiding this comment.
just saw that you merged this. Code looks good, just had a couple non-blocking comments.
| } | ||
|
|
||
| #[test] | ||
| fn scoped_concurrency() { |
There was a problem hiding this comment.
you might want to add a test for nested calls to scope. That was something that I saw deadlock in a couple of the other executors that I tested. In this case it'd be something like
THREAD_POOL.with_worker(|worker| {
scope(|scope| {
scope.spawn_on(worker, |_| {
THREAD_POOL.with_worker(|worker| {
scope(|scope| {
scope.spawn_on(worker, |_| {
string = "b";
})
});
});
})
});
});
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a large-scale overhaul of the scope implementation.
pinin favor of an unsafe assertion that scopes don't move.Pinturned out to be far more haste than it was worth.