[19.0][FIX] contract: exclude archived products from the line picker#1460
Merged
Merged
Conversation
pedrobaeza
reviewed
Jun 12, 2026
bosd
force-pushed
the
19.0-fix-contract-archived-product
branch
from
77269b5 to
b450faf
Compare
pedrobaeza
approved these changes
Jun 15, 2026
Member
|
Ouch, my bad, I have merged directly without ocabot (mixed with opened tabs in OpenUpgrade). Sorry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split out from #1427 (per @pedrobaeza's request to break the big PR into focused ones).
Excludes archived products from the contract line product picker.
Context: the
active_test: Falseoncontract_line_ids— added in d25115d ("No contract line and invoices when contract is archived") to keep archived contract lines visible — leaks into the embedded product search and surfaces archived products. Because a view-leveldomainattribute replaces the model field domain (they don't AND together), each customer/supplier line view re-asserts('active', '=', True). Happy to switch to re-assertingactive_test: Trueon the product field instead if preferred.