[19.0][FIX] update pre-commit-config#724
Conversation
eugenios73
force-pushed
the
19.0-FIX-update-pre-commit-config
branch
from
7b74551 to
b114398
Compare
|
This PR has the |
|
@OCA/crm-sales-marketing-maintainers Please, can you review/merge this PR? |
|
@pedrobaeza Please can you review / mergtte this PR ? |
pedrobaeza
left a comment
pedrobaeza
left a comment
There was a problem hiding this comment.
Please don't do this manually, but run copier update.
eugenios73
force-pushed
the
19.0-FIX-update-pre-commit-config
branch
from
b114398 to
0ab30eb
Compare
eugenios73
force-pushed
the
19.0-FIX-update-pre-commit-config
branch
2 times, most recently
from
2f3cc54 to
3e326ac
Compare
OCA-git-bot
added
mod:crm_claim
eugenios73
force-pushed
the
19.0-FIX-update-pre-commit-config
branch
from
3e326ac to
e4a29d2
Compare
|
Hi again @pedrobaeza , I've already applied the changes you mentioned and fixed some new errors in the repository modules that weren't showing up before the update. As for the error appearing in the tests, I've already solved it in PR #712. Thanks in advance. |
pedrobaeza
left a comment
pedrobaeza
left a comment
There was a problem hiding this comment.
I also miss the file .gitattributes or similar.
| @@ -1,3 +0,0 @@ | |||
| [checklog-odoo] | |||
There was a problem hiding this comment.
The latest copier template doesn't remove this file. On contrary, it includes more lines.
There was a problem hiding this comment.
@pedrobaeza Apologies, I have re-added the checklog-odoo.cfg file; I'm not sure why it had been deleted. The .gitattributes file is not in the commit because there haven't been any changes. I'm not entirely sure if this is correct. Is that possible?
There was a problem hiding this comment.
And what about the new lines added here?
There was a problem hiding this comment.
@pedrobaeza to ensure the process was right, I reset my local branch to the state before the changes and checked for any updates in the source branch. I re-ran update copier --trust, double-checking every prompt, but the result was identical: it deletes the checklog-odoo.cfg file and makes no changes to .gitattributes. Could you check if this is expected or if there's an issue with the copier update? I've attached screenshots of the modified files after running the command and the copier prompts.
There was a problem hiding this comment.
Copier sometimes fail as it seems. The complete file should be: https://github.com/OCA/oca-addons-repo-template/blob/master/src/%7B%25%20if%20enable_checklog_odoo%20%25%7Dchecklog-odoo.cfg%7B%25%20endif%20%25%7D
Anyway, the CI right now is red.
eugenios73
force-pushed
the
19.0-FIX-update-pre-commit-config
branch
from
e4a29d2 to
0a0a75d
Compare
|
OK, seeing that you fix it in other PR. I'm merging this manually. |
6 participants
The update to pre-commit-config resolves the issue with the command, which appears to be outdated due to the change in version 19.0 to the "user_ids" attribute of the "ir.filters" base model. This attribute has changed compared to version 18.0, where it was "user_id". The commit showing this change can be found here: odoo/odoo@414e55c