[18.0][FIX] base_user_role: remove active field from res.users.role.line#444
Open
[18.0][FIX] base_user_role: remove active field from res.users.role.line#444
Conversation
The `active` field was added in PR OCA#167 to exclude archived users from the role list view count. However, it causes Odoo's active_test filtering to silently hide role lines of archived users from the role form view, making it impossible to audit role assignments. Replace it with a domain on `line_ids` to filter archived users without the active_test side effect.
Contributor
| _name = "res.users.role.line" | ||
| _description = "Users associated to a role" | ||
|
|
||
| active = fields.Boolean(related="user_id.active") |
There was a problem hiding this comment.
Do we still need this filtering?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
activefield was added in PR #167 to exclude archived users from the role list view count. However, it causes Odoo's active_test filtering to silently hide role lines of archived users from the role form view, making it impossible to audit role assignments.Replace it with a domain on
line_idsto filter archived users without the active_test side effect.@qrtl QT6433