Skip to content

[18.0][FIX] base_user_role: remove active field from res.users.role.line #444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kanda999 wants to merge 1 commit into
base: 18.0
Choose a base branch
from
+4 −2
Open

[18.0][FIX] base_user_role: remove active field from res.users.role.line #444

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions base_user_role/models/role.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,10 @@ class ResUsersRole(models.Model):
string="Associated group",
)
line_ids = fields.One2many(
comodel_name="res.users.role.line", inverse_name="role_id", string="Role lines"
comodel_name="res.users.role.line",
inverse_name="role_id",
string="Role lines",
domain=[("user_id.active", "=", True)],
)
user_ids = fields.One2many(
comodel_name="res.users", string="Users list", compute="_compute_user_ids"
Expand Down Expand Up @@ -134,7 +137,6 @@ class ResUsersRoleLine(models.Model):
_name = "res.users.role.line"
_description = "Users associated to a role"

active = fields.Boolean(related="user_id.active")
Copy link
Copy Markdown

@AungKoKoLin1997 AungKoKoLin1997 Apr 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still need this filtering?

server-backend/base_user_role/models/user.py

Line 37 in ff48dc7

for role_line in default_user.with_context(active_test=False).role_line_ids:

role_id = fields.Many2one(
comodel_name="res.users.role", required=True, string="Role", ondelete="cascade"
)
Expand Down
Loading