Fix release job condition#43
Conversation
There was a problem hiding this comment.
Pull request overview
Adjusts the GitHub Actions release workflow so the “Create GitHub Release” job actually runs for release-triggered executions, while skipping manual workflow dispatch runs.
Changes:
- Update the
releasejob condition to run when the workflow is triggered by areleaseevent (and not when manually dispatched).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| needs: build | ||
| runs-on: ubuntu-latest | ||
| if: github.event_name == 'push' | ||
| if: github.event_name != 'workflow_dispatch' |
There was a problem hiding this comment.
For clarity and to avoid this job running unexpectedly if additional triggers are added later, consider making this condition explicit (e.g., run only when github.event_name == 'release') rather than excluding workflow_dispatch.
| if: github.event_name != 'workflow_dispatch' | |
| if: github.event_name == 'release' |
| needs: build | ||
| runs-on: ubuntu-latest | ||
| if: github.event_name == 'push' | ||
| if: github.event_name != 'workflow_dispatch' |
There was a problem hiding this comment.
PR description currently contains a placeholder closes #. The repo's PR-body validation workflow requires closes|fixes|resolves #<issue> with a real issue number; otherwise CI will fail. Please update the PR description accordingly.
Description
Closes
closes #