Skip to content

Fix release job condition #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
OGR-67 merged 2 commits into from
Mar 22, 2026
Merged

Fix release job condition #43

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c255d3e
Merge pull request #42 from OGR-67/dev
OGR-67 Mar 22, 2026
9326cda
Change release condition to exclude workflow_dispatch
OGR-67 Mar 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ jobs:
name: Create GitHub Release
needs: build
runs-on: ubuntu-latest
if: github.event_name == 'push'
if: github.event_name != 'workflow_dispatch'

Copilot AI Mar 22, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For clarity and to avoid this job running unexpectedly if additional triggers are added later, consider making this condition explicit (e.g., run only when github.event_name == 'release') rather than excluding workflow_dispatch.

Suggested change
if: github.event_name != 'workflow_dispatch'
if: github.event_name == 'release'

Copilot uses AI. Check for mistakes.

Copilot AI Mar 22, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR description currently contains a placeholder closes #. The repo's PR-body validation workflow requires closes|fixes|resolves #<issue> with a real issue number; otherwise CI will fail. Please update the PR description accordingly.

Copilot uses AI. Check for mistakes.
permissions:
contents: write

Expand Down
Loading