Skip to content

Dev#44

Merged
OGR-67 merged 2 commits into
mainfrom
dev
Mar 22, 2026
Merged

Dev#44
OGR-67 merged 2 commits into
mainfrom
dev

Conversation

@OGR-67

@OGR-67 OGR-67 commented Mar 22, 2026

Copy link
Copy Markdown
Owner

Description

Closes

closes #

Copilot AI review requested due to automatic review settings March 22, 2026 10:58
@OGR-67 OGR-67 merged commit 666e69c into main Mar 22, 2026
3 of 4 checks passed

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the GitHub Actions release workflow so the “Create GitHub Release” job runs under the intended trigger(s), aligning release automation with the workflow’s on: release configuration.

Changes:

  • Adjusted the if: condition for the release job to prevent it from running on workflow_dispatch.
  • Effectively fixes the prior condition that would never run under the current workflow triggers.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

needs: build
runs-on: ubuntu-latest
if: github.event_name == 'push'
if: github.event_name != 'workflow_dispatch'

Copilot AI Mar 22, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The condition github.event_name != 'workflow_dispatch' is equivalent to github.event_name == 'release' for this workflow and is less explicit/future-proof (if additional triggers are added later, this job may start running unexpectedly). Prefer an allow-list check like github.event_name == 'release' (or checking github.event.action == 'published') to make the intent clear.

Suggested change
if: github.event_name != 'workflow_dispatch'
if: github.event_name == 'release'

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants