Skip to content

Dev #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
OGR-67 merged 2 commits into from
Mar 22, 2026
Merged

Dev #44

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9326cda
Change release condition to exclude workflow_dispatch
OGR-67 Mar 22, 2026
6e2d5d9
Merge pull request #43 from OGR-67/Fix-release-job-condition
OGR-67 Mar 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ jobs:
name: Create GitHub Release
needs: build
runs-on: ubuntu-latest
if: github.event_name == 'push'
if: github.event_name != 'workflow_dispatch'

Copilot AI Mar 22, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The condition github.event_name != 'workflow_dispatch' is equivalent to github.event_name == 'release' for this workflow and is less explicit/future-proof (if additional triggers are added later, this job may start running unexpectedly). Prefer an allow-list check like github.event_name == 'release' (or checking github.event.action == 'published') to make the intent clear.

Suggested change
if: github.event_name != 'workflow_dispatch'
if: github.event_name == 'release'

Copilot uses AI. Check for mistakes.
permissions:
contents: write

Expand Down
Loading