Skip to content

ci: keep Lume contract on hosted runners #130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jmcte merged 3 commits into from
May 31, 2026
Merged

ci: keep Lume contract on hosted runners #130

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bd9337f
ci: run docker and security checks on hosted runners
jmcte May 31, 2026
62dc49b
ci: keep lume contract on hosted runners
jmcte May 31, 2026
7700d1e
Merge branch 'main' into codex/finish-runner-fleet-up-to-date
jmcte May 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,11 +173,7 @@ jobs:
lume_macos_contract_trusted:
name: lume macos contract
if: github.event_name != 'pull_request' || github.event.pull_request.head.repo.full_name == github.repository
runs-on:
- self-hosted
- macOS
- ARM64
- xcode
runs-on: ubuntu-latest
timeout-minutes: 20
steps:
- uses: actions/checkout@v6
Expand Down
5 changes: 2 additions & 3 deletions test/workflow.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ import YAML from "yaml";
import { describe, expect, test } from "vitest";

const shellSafePublicRunner = ["self-hosted", "linux", "shell-only", "public"];
const macosXcodeRunner = ["self-hosted", "macOS", "ARM64", "xcode"];

describe("CI workflow", () => {
test("runs mutation testing in extended validation and uploads the report", () => {
Expand Down Expand Up @@ -291,7 +290,7 @@ describe("CI workflow", () => {
expect(String(syntaxStep?.run)).toContain("docker/runner-entrypoint.ps1");
});

test("keeps the Lume macOS pool contract on self-hosted macOS runners", () => {
test("keeps the Lume macOS pool contract on GitHub-hosted runners", () => {
const workflow = YAML.parse(
fs.readFileSync(path.resolve(".github/workflows/ci.yml"), "utf8")
) as {
Expand All @@ -310,7 +309,7 @@ describe("CI workflow", () => {
(step) => step.name === "Validate Lume shell scripts"
);

expect(lumeJob["runs-on"]).toEqual(macosXcodeRunner);
expect(lumeJob["runs-on"]).toBe("ubuntu-latest");
expect(String(renderStep?.run)).toContain("pnpm validate-lume-config");
expect(String(renderStep?.run)).toContain("pnpm render-lume-runner-manifest");
expect(String(lifecycleStep?.run)).toContain("pnpm install-lume-project");
Expand Down
Loading