Open
Conversation
- Add game_id validation in PlayerLive.Show.handle_params/3 - Add player-game validation in ApiController.play_card/3 - Implement security audit logging with IP addresses - Return proper error responses for unauthorized access - Prevent cross-game player data access Security: Eliminates CVSS 9.1 critical vulnerability Impact: Zero breaking changes to legitimate functionality This commit contains only the core security fixes for IDOR vulnerability.
- Update PlayerLive.Show logging to use database values instead of URL parameters - Prevent potential injection attacks in security audit logs - Use player.id and player.game_id from verified database records - Maintain security validation while eliminating log injection risks
khushal-winner
requested review from
cw-owasp,
rewtd and
sydseter
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes - #2514
Add game_id validation in PlayerLive.Show.handle_params/3
Add player-game validation in ApiController.play_card/3
Return proper error responses for unauthorized access
Prevent cross-game player data access
2026-03-05.03-34-40.mp4
2026-03-05.19-21-01.mp4