feat: redirect players to game page when game ends#2544
Open
khushal-winner wants to merge 1 commit intoOWASP:masterfrom
Open
feat: redirect players to game page when game ends#2544khushal-winner wants to merge 1 commit intoOWASP:masterfrom
khushal-winner wants to merge 1 commit intoOWASP:masterfrom
Conversation
- Add game_finished?/1 function to Game module - Implement game-end redirect in PlayerLive.Show - Redirect from /games/:game_id/players/:player_id to /games/:game_id - Handle both initial access and real-time game end events - Use push_navigate for seamless LiveView redirects Fixes issue where players could access finished game pages instead of being redirected to game summary.
sydseter
approved these changes
Mar 12, 2026
Collaborator
|
I’ll need to test this out, but it looks good. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes - #2539
2026-03-06.23-35-50.mp4
Fixes issue where players could access finished game pages instead of being redirected to game summary.