Fix Vote schema empty changeset validation#2628
Open
xovishnukosuri wants to merge 1 commit intoOWASP:masterfrom
Open
Fix Vote schema empty changeset validation#2628xovishnukosuri wants to merge 1 commit intoOWASP:masterfrom
xovishnukosuri wants to merge 1 commit intoOWASP:masterfrom
Conversation
The Vote changeset was casting no fields and validating nothing, violating Ecto best practices. Update to cast and require :dealt_card_id and :player_id, matching the ContinueVote pattern. Add corresponding unit tests. Closes OWASP#2557 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
xovishnukosuri
requested review from
cw-owasp,
rewtd and
sydseter
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Vote.changeset/2to cast and validate[:dealt_card_id, :player_id]instead of empty listsContinueVoteTestpatternCloses #2557
Test plan
mix test test/copi/cornucopia/vote_test.exspasses (changeset accepts valid attrs, rejects nil values)mix test)🤖 Generated with Claude Code