Skip to content

Fix Vote schema empty changeset validation #2628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
xovishnukosuri wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix Vote schema empty changeset validation #2628

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions copi.owasp.org/lib/copi/cornucopia/vote.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ defmodule Copi.Cornucopia.Vote do
@doc false
def changeset(vote, attrs) do
vote
|> cast(attrs, [])
|> validate_required([])
|> cast(attrs, [:dealt_card_id, :player_id])
|> validate_required([:dealt_card_id, :player_id])
end
end
22 changes: 22 additions & 0 deletions copi.owasp.org/test/copi/cornucopia/vote_test.exs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
defmodule Copi.Cornucopia.VoteTest do
use Copi.DataCase

alias Copi.Cornucopia.Vote

describe "votes" do
@valid_attrs %{player_id: Ecto.ULID.generate(), dealt_card_id: 1}
@invalid_attrs %{player_id: nil, dealt_card_id: nil}

test "changeset with valid attributes" do
changeset = Vote.changeset(%Vote{}, @valid_attrs)
assert changeset.valid?
end

test "changeset with invalid attributes" do
changeset = Vote.changeset(%Vote{}, @invalid_attrs)
refute changeset.valid?
assert "can't be blank" in errors_on(changeset).player_id
assert "can't be blank" in errors_on(changeset).dealt_card_id
end
end
end
Loading