chore: rename YamlLoader to SafeLoader#296
Merged
Merged
Conversation
Signed-off-by: Morgan Epp <60796713+epmog@users.noreply.github.com>
godobyte
approved these changes
Jun 29, 2026
|
Curious what's the context for this change, which scanner you're referring to? |
seant-aws
approved these changes
Jun 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was the problem/requirement? (What/Why)
Scanner flagging yaml.load instead of yaml.safe_load.
What was the solution? (How)
safe_load does what we do, but we also allow the c-extension if it exists: https://github.com/yaml/pyyaml/blob/34a9bf82357f4952d8f194a5a31f1c39743652d0/lib/yaml/__init__.py#L125
Probably won't stop it, but changed the import aliases to reflect we're using SafeLoader regardless of c-extension.
What is the impact of this change?
Scanner reports reduced.
How was this change tested?
Was this change documented?
N/A
Is this a breaking change?
N/a
Does this change impact security?
N/A
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.