Skip to content

chore: rename YamlLoader to SafeLoader #296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
epmog merged 1 commit into from
Jun 29, 2026
Merged

chore: rename YamlLoader to SafeLoader #296

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions test/openjd/model_v0/benchmark/test_yaml_loader_performance.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,17 +164,17 @@ def benchmark_loader(
# Select the appropriate loader directly
if loader_type == "CSafeLoader":
try:
from yaml import CSafeLoader as YamlLoader # type: ignore[attr-defined]
from yaml import CSafeLoader as SafeLoader # type: ignore[attr-defined]
except ImportError:
from yaml import SafeLoader as YamlLoader # type: ignore[assignment]
from yaml import SafeLoader # type: ignore[assignment]
else:
from yaml import SafeLoader as YamlLoader # type: ignore[assignment]
from yaml import SafeLoader # type: ignore[assignment]

for _ in range(iterations):
start_time = time.perf_counter()
# Parse YAML directly instead of using document_string_to_object
# to avoid the module-level loader selection
yaml.load(template_content, Loader=YamlLoader)
yaml.load(template_content, Loader=SafeLoader)
end_time = time.perf_counter()
times.append((end_time - start_time) * 1000) # Convert to milliseconds

Expand Down
8 changes: 4 additions & 4 deletions test/openjd/model_v1/benchmark/test_yaml_loader_performance.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,17 +164,17 @@ def benchmark_loader(
# Select the appropriate loader directly
if loader_type == "CSafeLoader":
try:
from yaml import CSafeLoader as YamlLoader # type: ignore[attr-defined]
from yaml import CSafeLoader as SafeLoader # type: ignore[attr-defined]
except ImportError:
from yaml import SafeLoader as YamlLoader # type: ignore[assignment]
from yaml import SafeLoader # type: ignore[assignment]
else:
from yaml import SafeLoader as YamlLoader # type: ignore[assignment]
from yaml import SafeLoader # type: ignore[assignment]

for _ in range(iterations):
start_time = time.perf_counter()
# Parse YAML directly instead of using document_string_to_object
# to avoid the module-level loader selection
yaml.load(template_content, Loader=YamlLoader)
yaml.load(template_content, Loader=SafeLoader)
end_time = time.perf_counter()
times.append((end_time - start_time) * 1000) # Convert to milliseconds

Expand Down
Loading