fix: stored XSS in generate_cml_map (hotfix 2)#39
Merged
Conversation
- Use json.dumps() for cml_ids_json instead of str/replace to prevent JSON injection in the inline <script> block - Use json.dumps() for JS onclick argument and markupsafe.escape() for HTML display context in popup_html to prevent stored XSS via cml_id Closes webserver-hotfix-plan.md Fix 2
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #39 +/- ##
==========================================
- Coverage 78.93% 78.88% -0.05%
==========================================
Files 24 24
Lines 2317 2321 +4
==========================================
+ Hits 1829 1831 +2
- Misses 488 490 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes webserver-hotfix-plan.md Fix 2