Skip to content

fix: stored XSS in generate_cml_map (hotfix 2) #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cchwala merged 1 commit into from
Apr 29, 2026
Merged

fix: stored XSS in generate_cml_map (hotfix 2) #39

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions webserver/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,11 @@
import json
import os
import time
import math
import psycopg2
import folium
import requests
from markupsafe import escape
from flask import Flask, render_template, request, jsonify, Response, redirect
from datetime import datetime, timedelta
from pathlib import Path
Expand Down Expand Up @@ -124,7 +126,7 @@ def generate_cml_map():
m = folium.Map(location=[avg_lat, avg_lon], zoom_start=8)

# Store CML IDs list for JavaScript
cml_ids_json = str([str(row[0]) for row in data]).replace("'", '"')
cml_ids_json = json.dumps([str(row[0]) for row in data])

# Add CML lines with onclick handlers
for idx, row in enumerate(data):
Expand All @@ -147,10 +149,12 @@ def generate_cml_map():
}

# Create a custom popup with onclick
cml_id_js = json.dumps(str(cml_id))
cml_id_html = str(escape(cml_id))
popup_html = f"""
<div>
<strong>CML ID: {cml_id}</strong><br>
<button onclick="window.handleCmlClick('{cml_id}'); return false;" style="margin-top: 5px; padding: 5px 10px; background-color: #0066cc; color: white; border: none; border-radius: 3px; cursor: pointer;">
<strong>CML ID: {cml_id_html}</strong><br>
<button onclick="window.handleCmlClick({cml_id_js}); return false;" style="margin-top: 5px; padding: 5px 10px; background-color: #0066cc; color: white; border: none; border-radius: 3px; cursor: pointer;">
Load Data
</button>
</div>
Expand Down
Loading