PHP 8.4 polyfill: update false positive prevention#91
Merged
Conversation
Member
Author
|
Note: this PR won't fix the CI build failure completely (yet), but is step two of three towards fixing the CI failure. |
jrfnl
force-pushed
the
feature/sync-with-polyfill-v1.34.0-2
branch
2 times, most recently
from
46e8c87 to
8b1ad66
Compare
The PHP cross-version compatibility bug regarding the `Deprecated` attribute, which I previously reported to Symfony has been fixed. This commit updates the ruleset to allow for the fix and prevent false positives on the new code introduced. Refs: * symfony/polyfill 551 * symfony/polyfill 556
jrfnl
force-pushed
the
feature/sync-with-polyfill-v1.34.0-2
branch
from
8b1ad66 to
bc17912
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PHP cross-version compatibility bug regarding the
Deprecatedattribute, which I previously reported to Symfony, has been fixed.This commit updates the ruleset to allow for the fix and prevent false positives on the new code introduced.
Refs: