Skip to content

PHP 8.4 polyfill: update false positive prevention #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jrfnl merged 1 commit into from
Jun 21, 2026
Merged

PHP 8.4 polyfill: update false positive prevention #91

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions PHPCompatibilitySymfonyPolyfillPHP84/ruleset.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,9 +39,11 @@
<exclude-pattern>/polyfill-php84/Php84\.php$</exclude-pattern>
</rule>
<rule ref="PHPCompatibility.Attributes.NewAttributes.PHPNativeAttributeFound">
<exclude-pattern>/polyfill-php84/Resources/Deprecated\.php$</exclude-pattern>
<exclude-pattern>/polyfill-php84/Resources/stubs/Deprecated\.php$</exclude-pattern>
</rule>
<rule ref="PHPCompatibility.Classes.NewClasses.attributeFound">
<exclude-pattern>/polyfill-php84/Resources/Deprecated\.php$</exclude-pattern>
<exclude-pattern>/polyfill-php84/Resources/stubs/Deprecated\.php$</exclude-pattern>
</rule>
<rule ref="PHPCompatibility.FunctionUse.NewFunctions.get_debug_typeFound">
Expand All @@ -54,6 +56,7 @@

<!-- This is fine as the autoloading for this file should only ever be triggered when on PHP 8.0 or higher. -->
<rule ref="PHPCompatibility.Classes.NewTypedProperties.Found">
<exclude-pattern>/polyfill-php84/Resources/Deprecated\.php$</exclude-pattern>
<exclude-pattern>/polyfill-php84/Resources/stubs/Deprecated\.php$</exclude-pattern>
</rule>

Expand All @@ -74,13 +77,12 @@
<exclude-pattern>/polyfill-php84/Php84\.php$</exclude-pattern>
</rule>

<!--
Not a false positive, but a bug in the Symfony PHP 8.4 polyfill package.
Bug has been reported: https://github.com/symfony/polyfill/issues/551
Temporarily silencing the error as this needs to be solved upstream.
-->
<!-- See: https://github.com/symfony/polyfill/pull/556 -->
<rule ref="PHPCompatibility.Classes.NewReadonlyProperties.Found">
<!-- Polyfill v1.30.0 - v1.33.0 -->
<exclude-pattern>/polyfill-php84/Resources/stubs/Deprecated\.php$</exclude-pattern>
<!-- Polyfill >= v1.34.0 -->
<exclude-pattern>/polyfill-php84/Resources/Deprecated\.php$</exclude-pattern>
</rule>

</ruleset>
Loading