Skip to content

PMM-4879 Support for defaults file parameter.#2465

Closed
pkadej wants to merge 1 commit intoPercona-Lab:PMM-2.0from
pkadej:PMM-4879-defaults-file
Closed

PMM-4879 Support for defaults file parameter.#2465
pkadej wants to merge 1 commit intoPercona-Lab:PMM-2.0from
pkadej:PMM-4879-defaults-file

Conversation

@pkadej
Copy link

@pkadej pkadej commented Apr 20, 2022

PMM-4879

Build will fail because I cannot use forked version of api (pmm) as dependency in mod.go. To acomplish this, api needs be merged and version of pmm api should be bumped.

@YaroslavPodorvanov
Copy link

@pkadej see build

commands/management/add_mysql.go:205:4: unknown field 'DefaultsFile' in struct literal of type my_sql.AddMySQLBody

@pkadej
Copy link
Author

pkadej commented Apr 22, 2022

@YaroslavPodorvanov This fails because I cannot use forked version of api (pmm) as dependency in mod.go. Api needs to be merged and then version of pmm api - bumped.
Thanks :-)

@JNKPercona
Copy link
Collaborator

@JNKPercona
Copy link
Collaborator

API tests have failed, Please check: API: https://pmm.cd.percona.com/job/pmm2-api-tests/9910/

@JNKPercona
Copy link
Collaborator

UI tests have failed, Please check: UI: https://pmm.cd.percona.com/job/pmm2-ui-tests/15061/

@JNKPercona
Copy link
Collaborator

@JNKPercona
Copy link
Collaborator

API tests have failed, Please check: API: https://pmm.cd.percona.com/job/pmm2-api-tests/9936/

@JNKPercona
Copy link
Collaborator

UI tests have failed, Please check: UI: https://pmm.cd.percona.com/job/pmm2-ui-tests/15260/

@JNKPercona
Copy link
Collaborator

@JNKPercona
Copy link
Collaborator

API tests have failed, Please check: API: https://pmm.cd.percona.com/job/pmm2-api-tests/9937/

@JNKPercona
Copy link
Collaborator

pmm2-client testsuite has failed, Please check: BATS: https://pmm.cd.percona.com/job/pmm2-testsuite/9460/

@JNKPercona
Copy link
Collaborator

UI tests have failed, Please check: UI: https://pmm.cd.percona.com/job/pmm2-ui-tests/15261/

@JNKPercona
Copy link
Collaborator

@JNKPercona
Copy link
Collaborator

API tests have failed, Please check: API: https://pmm.cd.percona.com/job/pmm2-api-tests/9938/

@JNKPercona
Copy link
Collaborator

UI tests have failed, Please check: UI: https://pmm.cd.percona.com/job/pmm2-ui-tests/15262/

@pkadej pkadej force-pushed the PMM-4879-defaults-file branch from 90488f9 to fe16004 Compare May 26, 2022 21:43
@JNKPercona
Copy link
Collaborator

@JNKPercona
Copy link
Collaborator

API tests have failed, Please check: API: https://pmm.cd.percona.com/job/pmm2-api-tests/10142/

@JNKPercona
Copy link
Collaborator

UI tests have failed, Please check: UI: https://pmm.cd.percona.com/job/pmm2-ui-tests/16224/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants