PMM-4879 Added support for defaultsfile parameter.

[pkadej]

PMM-4879

Build: SUBMODULES-2465

• pmm
• pmm-managed
• pmm-agent

Build will fail because I cannot use forked version of api (pmm) as dependency in mod.go. To acomplish this, api needs be merged and version of pmm api should be bumped.

[it-percona-cla]

All committers have signed the CLA.

[ritbl]

Checked, and it doesn't work

➜  pmm-admin git:(PMM-4879-defaults-file) ✗ pmm-admin add mysql  --defaults-file=~/.my.cnf              
Connection check failed: Error 1045: Access denied for user 'root'@'172.30.0.1' (using password: NO).
➜  pmm-admin git:(PMM-4879-defaults-file) ✗ cat ~/.my.cnf 
[client]
host=127.0.0.1
port=12345
user=root
password=root-password

with explicit creds works just fine:

➜  pmm-admin git:(PMM-4879-defaults-file) ✗ pmm-admin add mysql --username=root --password=root-password
MySQL Service added.
Service ID  : /service_id/5972faf9-5bd1-403a-9ea6-661bcee16234
Service name: prime-u1-mysql

Table statistics collection enabled (the limit is 1000, the actual table count is 298).

[pkadej]

Checked, and it doesn't work

➜  pmm-admin git:(PMM-4879-defaults-file) ✗ pmm-admin add mysql  --defaults-file=~/.my.cnf              
Connection check failed: Error 1045: Access denied for user 'root'@'172.30.0.1' (using password: NO).
➜  pmm-admin git:(PMM-4879-defaults-file) ✗ cat ~/.my.cnf 
[client]
host=127.0.0.1
port=12345
user=root
password=root-password

with explicit creds works just fine:

➜  pmm-admin git:(PMM-4879-defaults-file) ✗ pmm-admin add mysql --username=root --password=root-password
MySQL Service added.
Service ID  : /service_id/5972faf9-5bd1-403a-9ea6-661bcee16234
Service name: prime-u1-mysql

Table statistics collection enabled (the limit is 1000, the actual table count is 298).

Local pmm-manage server need to be rebuild, e.g.:

make env TARGET=run-debug

[BupycHuk]

And for username let's use the same logic as for default address.

[pkadej]

Changed.

[pkadej]

This will fail for sure, linter doesnt allow to use replace with forked pmm/api:

go.mod:7:1: replacement are not allowed: github.com/percona/pmm (gomoddirectives)
replace github.com/percona/pmm => github.com/pkadej/pmm v0.0.0-20220427173424-9aa771bbf8c1