Skip to content

replace rsl::StaticVector by std::array #343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
christianrauch wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −6
Draft

replace rsl::StaticVector by std::array #343

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions generate_parameter_library_py/generate_parameter_library_py/cpp_conversions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,9 +49,9 @@ def __init__(self):
'double_array': lambda defined_type, templates: 'std::vector<double>',
'int_array': lambda defined_type, templates: 'std::vector<int64_t>',
'string_array': lambda defined_type, templates: 'std::vector<std::string>',
'double_array_fixed': lambda defined_type, templates: f'rsl::StaticVector<{templates[0]}, {templates[1]}>',
'int_array_fixed': lambda defined_type, templates: f'rsl::StaticVector<{templates[0]}, {templates[1]}>',
'string_array_fixed': lambda defined_type, templates: f'rsl::StaticVector<{templates[0]}, {templates[1]}>',
'double_array_fixed': lambda defined_type, templates: f'std::array<{templates[0]}, {templates[1]}>',
'int_array_fixed': lambda defined_type, templates: f'std::array<{templates[0]}, {templates[1]}>',
'string_array_fixed': lambda defined_type, templates: f'std::array<{templates[0]}, {templates[1]}>',
'string_fixed': lambda defined_type, templates: f'rsl::StaticString<{templates[1]}>',
}
self.yaml_type_to_as_function = {
Expand Down
5 changes: 2 additions & 3 deletions ...ter_library_py/generate_parameter_library_py/jinja_templates/cpp/parameter_library_header
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@
#include <fmt/ranges.h>

#include <rsl/static_string.hpp>
#include <rsl/static_vector.hpp>
#include <rsl/parameter_validators.hpp>

{% if user_validation_file|length -%}
Expand Down Expand Up @@ -60,8 +59,8 @@ template <size_t capacity>
}

template <typename T, size_t capacity>
[[nodiscard]] auto to_parameter_value(rsl::StaticVector<T, capacity> const& value) {
return rclcpp::ParameterValue(rsl::to_vector(value));
[[nodiscard]] auto to_parameter_value(std::array<T, capacity> const& value) {
return rclcpp::ParameterValue(std::vector<T>{value.begin(), value.end()});
}

{%- filter indent(width=4) %}
Expand Down
Loading