feat(catalog): export decodeManifest — shared validation for DSO and static plugins#156
Merged
Merged
Conversation
… for DSO and static plugins A host that registers statically linked plugins has to decode their embedded manifests itself (no DSO scan runs), and a private decoder invited a second, weaker re-implementation host-side — letting a malformed static plugin pass validation the DSO path would reject. decodeManifest(source_path, family, manifest_json) is now part of the pj_plugins/host/plugin_catalog.hpp API: required non-empty id/name/version, typed-field rejection, and the message-parser encoding requirement, identically for both discovery paths. Additive; no ABI or protocol change. Version 0.19.0.
facontidavide
force-pushed
the
feat/export-manifest-decoder
branch
from
July 19, 2026 19:54
9953f7d to
bd897c7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracts the manifest decoder from DSO discovery's private implementation into the
pj_plugins/host/plugin_catalog.hppAPI, so a host registering statically linked plugins (PJ4'sPluginRuntimeCatalog::registerStaticPlugins) applies the exact validation the DSO path applies — required non-emptyid/name/version, typed-field rejection, and the message-parserencodingrequirement — instead of re-implementing a weaker decoder.Found by two independent reviews of PJ4's static-plugin extraction converging on the same defect: the host-side duplicate decoder accepted manifests the DSO path rejects, which could evict a working DSO plugin in favor of an unusable static one.
Additive: no ABI, protocol, or behavior change for existing consumers. Version 0.19.0 (conanfile + recipe.yaml + CHANGELOG agree).
Consumer PR: PlotJuggler/PJ4 (static-plugin registration) builds against this.
🤖 Generated with Claude Code