Cover S3 prefix configuration

[Antoninj]

Summary

• Fill the new S3 Prefix field in the existing S3 and R2 storage channel E2E flow
• Reopen the created channel and assert the configured prefix is persisted

Dependency

• Depends on enhancement: add configurable S3 storage prefix portabase#356 because the Prefix field is introduced by that PR.
• This test is intended to pass when the reusable E2E workflow runs against the Portabase PR server image from #356.

Summary by CodeRabbit

• Tests
  • Updated end-to-end storage coverage to include editing an existing storage channel.
  • Added prefix values to S3 and R2 provider setups for more realistic test data.
  • Expanded the invalid-channel flow to verify the Prefix field is preserved when opening the edit screen and that the edit view can be canceled successfully.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: d85e1f27-e45b-4f76-8d0f-20432d618a39

📥 Commits

Reviewing files that changed from the base of the PR and between a4c8c47 and 19fd71f.

📒 Files selected for processing (1)

• src/storage/s3.spec.ts

📜 Recent review details

🔇 Additional comments (2)

src/storage/s3.spec.ts (2)

5-5: LGTM!

Also applies to: 16-16, 31-31

---

103-103: LGTM!

Also applies to: 112-116

---

📝 Walkthrough

Walkthrough

The S3 E2E spec now imports an edit helper and adds prefix values to the AWS S3 and Cloudflare R2 provider configs. The invalid-channel test fills the Prefix field on creation, then edits the channel to verify the Prefix value persists before cancelling.

Changes

S3 spec Prefix and edit flow

Layer / File(s)	Summary
Test helper import and provider prefix values src/storage/s3.spec.ts	Imports the edit helper and adds a prefix property to both the AWS S3 and Cloudflare R2 provider configs.
Invalid channel Prefix field and edit verification src/storage/s3.spec.ts	Fills the Prefix form field during invalid-channel creation, then edits the invalid channel, asserts the Edit Storage Channel heading and Prefix value, and cancels.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Sequence Diagram(s)

sequenceDiagram
  participant Test
  participant CreateChannelForm
  participant EditChannelScreen

  Test->>CreateChannelForm: fill Prefix field with provider.prefix
  Test->>CreateChannelForm: submit invalid channel
  Test->>EditChannelScreen: edit invalid channel
  EditChannelScreen-->>Test: show Edit Storage Channel heading
  EditChannelScreen-->>Test: Prefix field value equals provider.prefix
  Test->>EditChannelScreen: cancel edit

Loading

Poem

A prefix hopped in, snug and neat,
Through create and edit, a tidy feat,
I nibbled the code with careful care,
Checked each field was truly there,
Then cancelled out with a happy beat! 🐇

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately reflects the main change: adding and verifying S3 prefix configuration in the storage E2E flow.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}