Skip to content

Cover S3 prefix configuration #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Antoninj wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Cover S3 prefix configuration #11

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion src/storage/s3.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import {expect, test} from "@playwright/test";
import {getEnv} from "../helpers/env";
import {LOCAL_STORAGE_PATH} from "../helpers/session";
import {
cancel, create, get, remove, submit, testConnection, testFromEdit,
cancel, create, edit, get, remove, submit, testConnection, testFromEdit,
} from "../helpers/storage";

test.use({storageState: LOCAL_STORAGE_PATH});
Expand All @@ -13,6 +13,7 @@ const providers = [
requiredChannelName: "AWS S3 E2E Required",
optionalChannelName: "AWS S3 E2E Optional",
invalidChannelName: "AWS S3 E2E Invalid",
prefix: "e2e/aws-s3-prefix",
endpointUrl: getEnv("E2E_STORAGE_AWS_S3_ENDPOINT_URL"),
region: getEnv("E2E_STORAGE_AWS_S3_REGION"),
accessKey: getEnv("E2E_STORAGE_AWS_S3_ACCESS_KEY"),
Expand All @@ -27,6 +28,7 @@ const providers = [
requiredChannelName: "Cloudflare R2 E2E Required",
optionalChannelName: "Cloudflare R2 E2E Optional",
invalidChannelName: "Cloudflare R2 E2E Invalid",
prefix: "e2e/r2-prefix",
endpointUrl: getEnv("E2E_STORAGE_R2_ENDPOINT_URL"),
region: getEnv("E2E_STORAGE_R2_REGION"),
accessKey: getEnv("E2E_STORAGE_R2_ACCESS_KEY"),
Expand Down Expand Up @@ -98,6 +100,7 @@ for (const provider of providers) {
await page.getByLabel(/Access Key/).fill(provider.invalidAccessKey);
await page.getByLabel(/Secret Key/).fill(provider.invalidSecretKey);
await page.getByLabel(/Bucket name/).fill(provider.bucketName);
await page.getByLabel(/^Prefix$/).fill(provider.prefix);
await page.getByLabel(/^Port$/).fill(provider.port);
});
await expect(page.getByRole("heading", {name: "Add Storage Channel"})).toBeVisible();
Expand All @@ -106,6 +109,11 @@ for (const provider of providers) {
await submit(page);
await expect(page.getByText("Storage channel has been successfully created.")).toBeVisible();
await expect(get(page, provider.invalidChannelName)).toBeVisible();

await edit(page, provider.invalidChannelName);
await expect(page.getByRole("heading", {name: "Edit Storage Channel"})).toBeVisible();
await expect(page.getByLabel(/^Prefix$/)).toHaveValue(provider.prefix);
await cancel(page);
});

test(`Delete invalid ${provider.title} channel`, async ({page}) => {
Expand Down