Skip to content

fix: Render at-mentioned chips as @labels in task titles#2270

Merged
charlesvien merged 3 commits into
mainfrom
05-20-render_at-mentioned_chips_as_labels_in_task_titles
May 21, 2026
Merged

fix: Render at-mentioned chips as @labels in task titles#2270
charlesvien merged 3 commits into
mainfrom
05-20-render_at-mentioned_chips_as_labels_in_task_titles

Conversation

@charlesvien
Copy link
Copy Markdown
Member

@charlesvien charlesvien commented May 20, 2026

Problem

At-mentioned directories (and other chip types) rendered as raw XML like <folder path="products/agentic_tests" /> in task titles instead of human-readable text.

Closes #2172

Changes

  1. Add xmlToPlainText helper composing xmlToContent + contentToPlainText
  2. Use it in the task-creation saga so every chip type renders as @label
  3. Drop unused createFileTagRegex import from the saga
  4. Update attachment-only saga test (now shows @tmp/code.ts instead of "Reading attachment…")
  5. Add folder-mention regression test plus xmlToPlainText unit tests

How did you test this?

Manually

Publish to changelog?

no

@charlesvien charlesvien changed the title Render at-mentioned chips as @labels in task titles fix: Render at-mentioned chips as @labels in task titles May 20, 2026
@charlesvien charlesvien force-pushed the 05-20-buffer_feature-flag_subscribers_registered_before_init branch from 333b7f9 to 4e41951 Compare May 21, 2026 00:07
@charlesvien charlesvien force-pushed the 05-20-render_at-mentioned_chips_as_labels_in_task_titles branch from 1b02670 to 0b8803b Compare May 21, 2026 00:07
@charlesvien charlesvien marked this pull request as ready for review May 21, 2026 00:44
@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented May 21, 2026

Prompt To Fix All With AI
Fix the following 1 code review issue. Work through them one at a time, proposing concise fixes.

---

### Issue 1 of 1
apps/code/src/renderer/features/message-editor/utils/content.test.ts:200-241
**Prefer parameterised tests for `xmlToPlainText`**

The six new `it(...)` blocks all follow the same `xmlToPlainText(input) → expected` shape and should be collapsed into a single `it.each` table per the team's stated simplicity rule. Additionally, they are placed inside `describe("xmlToContent")` rather than their own `describe("xmlToPlainText")` block, which makes the test output misleading. The `github_pr`/`github_issue` test (lines 224-235) also packs two unrelated cases into one `it`, which hides which case fails on a first run.

Reviews (1): Last reviewed commit: "polish chip-aware title refactor" | Re-trigger Greptile

@charlesvien charlesvien force-pushed the 05-20-buffer_feature-flag_subscribers_registered_before_init branch from 4e41951 to 6261888 Compare May 21, 2026 02:10
@charlesvien charlesvien force-pushed the 05-20-render_at-mentioned_chips_as_labels_in_task_titles branch 2 times, most recently from 2f5cde6 to bef2ea7 Compare May 21, 2026 03:44
@charlesvien charlesvien force-pushed the 05-20-buffer_feature-flag_subscribers_registered_before_init branch from 6261888 to becc21c Compare May 21, 2026 03:44
@charlesvien charlesvien changed the base branch from 05-20-buffer_feature-flag_subscribers_registered_before_init to graphite-base/2270 May 21, 2026 07:54
@charlesvien charlesvien force-pushed the 05-20-render_at-mentioned_chips_as_labels_in_task_titles branch from bef2ea7 to 1f8e0f5 Compare May 21, 2026 07:54
@charlesvien charlesvien force-pushed the graphite-base/2270 branch from becc21c to 7cbdfb1 Compare May 21, 2026 07:54
@graphite-app graphite-app Bot changed the base branch from graphite-base/2270 to main May 21, 2026 07:55
@graphite-app
Copy link
Copy Markdown

graphite-app Bot commented May 21, 2026

Merge activity

  • May 21, 7:55 AM UTC: Graphite rebased this pull request, because this pull request is set to merge when ready.
  • May 21, 11:36 AM UTC: Graphite couldn't merge this PR because it failed for an unknown reason (GitHub is reporting that this PR is not mergeable, despite passing required status checks defined by your branch protection rules. Please check your rulesets for additional blocking criteria. Graphite Merge Queue does not currently support rulesets. Please contact Graphite support for further assistance.).

@charlesvien charlesvien merged commit 4c5bf3a into main May 21, 2026
11 of 16 checks passed
@charlesvien charlesvien deleted the 05-20-render_at-mentioned_chips_as_labels_in_task_titles branch May 21, 2026 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

At-mentions of directories render as raw XML in task titles

2 participants