fix: Render at-mentioned chips as @labels in task titles#2270
Merged
charlesvien merged 3 commits intoMay 21, 2026
Conversation
This was referenced May 20, 2026
Member
Author
This was referenced May 20, 2026
333b7f9 to
4e41951
Compare
1b02670 to
0b8803b
Compare
Contributor
Prompt To Fix All With AIFix the following 1 code review issue. Work through them one at a time, proposing concise fixes.
---
### Issue 1 of 1
apps/code/src/renderer/features/message-editor/utils/content.test.ts:200-241
**Prefer parameterised tests for `xmlToPlainText`**
The six new `it(...)` blocks all follow the same `xmlToPlainText(input) → expected` shape and should be collapsed into a single `it.each` table per the team's stated simplicity rule. Additionally, they are placed inside `describe("xmlToContent")` rather than their own `describe("xmlToPlainText")` block, which makes the test output misleading. The `github_pr`/`github_issue` test (lines 224-235) also packs two unrelated cases into one `it`, which hides which case fails on a first run.
Reviews (1): Last reviewed commit: "polish chip-aware title refactor" | Re-trigger Greptile |
4e41951 to
6261888
Compare
2f5cde6 to
bef2ea7
Compare
6261888 to
becc21c
Compare
bef2ea7 to
1f8e0f5
Compare
becc21c to
7cbdfb1
Compare
Merge activity
|
jonathanlab
approved these changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Problem
At-mentioned directories (and other chip types) rendered as raw XML like
<folder path="products/agentic_tests" />in task titles instead of human-readable text.Closes #2172
Changes
xmlToPlainTexthelper composingxmlToContent+contentToPlainText@labelcreateFileTagRegeximport from the saga@tmp/code.tsinstead of "Reading attachment…")xmlToPlainTextunit testsHow did you test this?
Manually
Publish to changelog?
no