fix: Preserve cloud reasoning level after initial prompt#2272
Merged
charlesvien merged 3 commits intoMay 21, 2026
Merged
Conversation
This was referenced May 21, 2026
Member
Author
286cab6 to
a9452b8
Compare
a8d5547 to
53893d0
Compare
a9452b8 to
22da025
Compare
53893d0 to
a0fd88e
Compare
Contributor
Prompt To Fix All With AIFix the following 1 code review issue. Work through them one at a time, proposing concise fixes.
---
### Issue 1 of 1
apps/code/src/renderer/features/sessions/service/service.test.ts:3482
**Prefer parameterised tests for the two `sendPrompt` effort cases**
The two new tests ("preserves prior reasoning effort…" and "uses newRun.reasoning_effort over prior effort…") are structurally identical — they share all mock setup and only differ in `priorEffort`, `newRun.reasoning_effort`, and the expected `initialReasoningEffort`. The team rule is to prefer parameterised tests; an `it.each` table over `[priorEffort, newRunEffort, expected]` rows would express both cases with no duplication and make future variants (e.g. `undefined` vs `null` inputs) trivial to add.
Reviews (1): Last reviewed commit: "refactor watchCloudTask to options bag" | Re-trigger Greptile |
f6f4589 to
ca5dc22
Compare
e5384e1 to
942f2bf
Compare
ca5dc22 to
a19b8e0
Compare
942f2bf to
2011089
Compare
jonathanlab
approved these changes
May 21, 2026
Merge activity
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Problem
Cloud task reasoning level dropdown resets from the user's chosen value (e.g. "max") to "high" after the initial prompt, so follow-up resumed runs use the wrong effort.
Closes #2167
Changes
task.latest_run.reasoning_effortinuseSessionConnectionand thread it intowatchCloudTaskinitialReasoningEffortparam towatchCloudTaskandfetchAndApplyCloudPreviewOptions"high"default with the run's actual value when merging preview config into the session, mirroring the existinginitialModelpatternHow did you test this?
Manually
Publish to changelog?
no