Conversation
…k.json This commit upgrades the @xmldom/xmldom package from version 0.8.12 to 0.8.13 in the package-lock.json file. The update aims to enhance functionality and maintain compatibility with the latest tools and libraries.
This commit introduces a new script, `create-erc20-token.js`, for interactively deploying a BasicERC20 token. The script prompts for essential token configuration details such as name, symbol, total supply, and addresses for the minter and owner. Additionally, it updates the `package.json` file to include a new command, `create-erc20`, to facilitate the execution of this script. These changes enhance the deployment process for ERC20 tokens within the project.
…te key usage This commit adds cautionary notes to the `env.deployment.example` file regarding the use of plain private keys for deployment. It emphasizes that this approach is primarily for local/testing environments and advises against it for production deployments, recommending secure key management practices instead. These changes aim to enhance security awareness and promote best practices for handling sensitive information.
…Blox This commit improves the transaction handling in the EngineBlox library by enforcing target whitelisting during transaction execution and meta-transaction processing. It updates the `validateTransactionExists` function to ensure that transaction IDs are valid within the context of the current transaction counter. Additionally, it refines the documentation for the `executeTransaction` function to clarify the handling of transaction statuses and results. These changes aim to strengthen the security and reliability of transaction operations within the library.
…ation This commit removes the `DeadlineInPast` error from the EngineBlox library and updates related validation functions to improve clarity. The documentation for the `validateMetaTxDeadline` function is refined to specify that a meta-transaction deadline is valid if `block.timestamp` is equal to the deadline. Additionally, the commit updates various test cases to reflect this change, ensuring that the system accurately handles deadline validations for meta-transactions. These modifications aim to streamline error handling and enhance the overall robustness of transaction validation processes.
…rations This commit updates the Solidity compiler version from 0.8.34 to 0.8.35 in the foundry.toml, hardhat.config.ts, truffle-config.cjs, and various contract files. The change ensures compatibility with the latest features and improvements in the Solidity language, enhancing the overall development experience and security of the project.
This commit introduces the `isGrantRevocable` boolean to the function schema in the EngineBlox library, allowing for more flexible management of function permissions. When set to true, grants can be removed from any role, including protected roles, while still enforcing the `isProtected` constraint on unregistering functions. The documentation for `addFunctionToRole` and `removeFunctionFromRole` has been updated to reflect these changes, clarifying the conditions under which function permissions can be modified. Additionally, a new error, `GrantNotRevocable`, has been added to handle cases where non-revocable grants are attempted to be removed. These updates aim to improve the clarity and functionality of role management within the library.
…ssion management This commit adds the `isGrantRevocable` boolean to various function schemas across multiple libraries, including PayBlox, SimpleRWA20, SimpleVault, and GuardianSafe. This enhancement allows for more flexible management of function permissions, enabling grants to be removed from any role, including protected roles, when set to true. The change aims to improve the clarity and functionality of role management within the EngineBlox library, ensuring that permissions can be adjusted as needed while maintaining security constraints. Additionally, relevant tests and documentation have been updated to reflect this new capability.
…onality This commit removes the `MAX_RESULT_PREVIEW_BYTES` constant from the EngineBlox library and associated functions, streamlining the handling of returndata during transaction execution. The `_callWithBoundedReturndata` function has been eliminated, and the transaction execution process now directly utilizes the low-level `call` method. Additionally, documentation has been updated to clarify the changes in returndata handling, ensuring that the SDK and related components reflect the new approach. These modifications aim to enhance code clarity and reduce unnecessary complexity in the EngineBlox library.
This commit introduces a new `resultHash` field in the `TxRecord` structure to store a commitment to the execution returndata, improving the clarity and integrity of transaction results. The `TxExecutionResult` event is added to emit the full returndata only on terminal execution (COMPLETED/FAILED), allowing for better verification of execution outcomes. Documentation has been updated to reflect these changes, ensuring that the SDK and related components are aligned with the new transaction result handling approach. These modifications aim to enhance the robustness and transparency of transaction execution within the EngineBlox library.
…EngineBlox This commit introduces several improvements to the transaction event structure within the EngineBlox library. A new `resultHash` field has been added to the `TransactionEvent` and `TxExecutionResult` events, allowing for better tracking of execution outcomes. The `result` field in the `SecureOperationState` structure has been replaced with `resultHash`, which stores a keccak256 hash of the execution returndata, enhancing data integrity. Additionally, the documentation has been updated to reflect these changes, ensuring consistency across the SDK and related components. These modifications aim to improve the clarity and robustness of transaction handling in the EngineBlox library.
This commit refines the TxStatus enumeration in the EngineBlox library by removing the REJECTED state, which is not utilized in the current transaction flow. The changes ensure that the transaction statuses are more concise and relevant, focusing on the states that are actively used: UNDEFINED, PENDING, EXECUTING, PROCESSING_PAYMENT, CANCELLED, COMPLETED, and FAILED. Documentation and related tests have been updated to reflect this adjustment, enhancing clarity and maintaining ABI stability for future extensions. These modifications aim to improve the overall efficiency and readability of transaction status management within the EngineBlox library.
…ole changes This commit refines the broadcaster management functions in the SecureOwnable contract by changing the parameters of `updateBroadcasterRequest` and `executeBroadcasterUpdate` to accept addresses instead of an index. The new approach allows for more direct management of broadcaster roles by specifying the current broadcaster to replace or revoke. Additionally, the internal validation function `_validateBroadcasterUpdatePair` has been introduced to ensure proper role management during updates. Documentation has been updated to reflect these changes, enhancing clarity and usability in broadcaster role management.
…improved clarity This commit modifies the ABI definitions across multiple contracts, including AccountBlox, EngineBlox, SecureOwnable, SimpleRWA20, SimpleVault, and others. Key changes include the introduction of new error types, such as `AlreadyInitialized`, `BeforeReleaseTime`, and `ChainIdMismatch`, to enhance error handling. Additionally, the parameters for functions like `updateBroadcasterRequest` have been updated to accept addresses instead of indices, improving clarity in broadcaster management. The `receive` and `fallback` functions have been clearly defined to ensure proper handling of incoming transactions. Documentation has been updated to reflect these changes, ensuring consistency and clarity across the SDK and related components.
…ract This commit improves the validation logic in the `updateBroadcasterRequest` function of the SecureOwnable contract. It adds checks to prevent no-op replacements by ensuring that the new broadcaster is not the same as the current one. Additionally, it maintains existing checks to ensure that a new broadcaster cannot be set if they already hold the role. Corresponding unit tests have been added to verify these changes, ensuring robust error handling and clarity in broadcaster management.
…rship transfer tests This commit enhances the transaction retrieval logic in the `BroadcasterUpdateTests` and `OwnershipTransferTests` by ensuring that the transaction status is fetched correctly after cancellation and completion. The code has been updated to remove commented-out lines and streamline the retrieval process, improving readability and maintainability of the test scripts. Additionally, validation checks for transaction statuses have been reinforced to ensure accurate assertions during testing.
Contributor
|
Warning Review limit reached
Your plan includes 1 review of capacity. Refill in 54 minutes and 42 seconds. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more review capacity refills, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than trial, open-source, and free plans. In all cases, review capacity refills continuously over time. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (128)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.