Skip to content

Dev #179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JaCoderX merged 17 commits into from
May 24, 2026
Merged

Dev #179

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
08fc359
chore: update @xmldom/xmldom package to version 0.8.13 in package-loc…
JaCoderX Apr 24, 2026
88e50a0
feat: add script for deploying BasicERC20 token and update package.json
JaCoderX Apr 27, 2026
1a27971
chore: update env.deployment.example with security warnings for priva…
JaCoderX Apr 27, 2026
72d67da
refactor: enhance transaction validation and execution flow in Engine…
JaCoderX May 12, 2026
eee8361
refactor: remove DeadlineInPast error and enhance validation document…
JaCoderX May 12, 2026
b1a0e82
chore: upgrade Solidity compiler version to 0.8.35 across all configu…
JaCoderX May 12, 2026
5301814
refactor: enhance function permission management in EngineBlox
JaCoderX May 14, 2026
8071b44
refactor: introduce isGrantRevocable flag for enhanced function permi…
JaCoderX May 14, 2026
969f895
refactor: remove MAX_RESULT_PREVIEW_BYTES constant and related functi…
JaCoderX May 20, 2026
0a59fb0
refactor: enhance transaction result handling in EngineBlox
JaCoderX May 20, 2026
e1d2f74
refactor: enhance transaction event structure and result handling in …
JaCoderX May 20, 2026
9aa957d
refactor: streamline TxStatus enumeration by removing REJECTED state
JaCoderX May 20, 2026
9993182
refactor: update broadcaster management functions for address-based r…
JaCoderX May 23, 2026
e13f9a8
refactor: update ABI definitions and enhance function parameters for …
JaCoderX May 23, 2026
3f19495
refactor: enhance broadcaster update validation in SecureOwnable cont…
JaCoderX May 24, 2026
9a0e2ea
refactor: improve transaction retrieval logic in broadcaster and owne…
JaCoderX May 24, 2026
22c2983
Merge pull request #178 from PracticalParticle/work
JaCoderX May 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions TECHNICAL_OVERVIEW.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ Central state struct; all mutations go through EngineBlox.

### 3.2 TxStatus and TxAction (EngineBlox.sol)

- **TxStatus**: UNDEFINED, PENDING, EXECUTING, PROCESSING_PAYMENT, CANCELLED, COMPLETED, FAILED, REJECTED.
- **TxStatus**: UNDEFINED, PENDING, EXECUTING, PROCESSING_PAYMENT, CANCELLED, COMPLETED, FAILED.
Critical invariant: approval/execution/cancel only allowed when status is PENDING; status is set to EXECUTING (or CANCELLED) **before** any external call to prevent reentrancy-based bypass.
- **TxAction** (9 values): Distinguish **who** can do **what**:
- Time-delay: `EXECUTE_TIME_DELAY_REQUEST`, `EXECUTE_TIME_DELAY_APPROVE`, `EXECUTE_TIME_DELAY_CANCEL`
Expand Down Expand Up @@ -179,7 +179,7 @@ The protocol deliberately enforces the same security rules in multiple places. A
### 6.2 Custom Errors (SharedValidation.sol) — Canonical List

- **Address**: InvalidAddress, NotNewAddress, validateNotZeroAddress, validateAddressUpdate, validateTargetAddress, validateHandlerContract
- **Time / deadline**: InvalidTimeLockPeriod, TimeLockPeriodZero, DeadlineInPast, MetaTxExpired, BeforeReleaseTime, NewTimelockSame; validateReleaseTime, validateMetaTxDeadline
- **Time / deadline**: InvalidTimeLockPeriod, TimeLockPeriodZero, MetaTxExpired, BeforeReleaseTime, NewTimelockSame; validateReleaseTime, validateMetaTxDeadline
- **Permissions**: NoPermission, NoPermissionForFunction, RestrictedOwner, RestrictedOwnerRecovery, RestrictedRecovery, RestrictedBroadcaster, SignerNotAuthorized, OnlyCallableByContract
- **Transaction / state**: NotSupported, InvalidOperationType, ZeroOperationTypeNotAllowed, TransactionStatusMismatch, AlreadyInitialized, NotInitialized, TransactionIdMismatch, PendingSecureRequest
- **Signature / meta-tx**: InvalidSignatureLength, InvalidSignature, InvalidNonce, ChainIdMismatch, InvalidHandlerSelector, InvalidSValue, InvalidVValue, ECDSAInvalidSignature, GasPriceExceedsMax
Expand Down
Loading