Improvements to the chat panel for consideration

[Midway65]

Chat Window Improvements — Bug Fixes & New Features

---

Overview

All changes below are scoped to the chat window UI, its supporting components, and the CSS that governs it. No changes to the AI/LLM pipeline, embeddings, MCP, or schema migrations are included. Every change is a self-contained fix or a discrete new feature — no architectural rewrites.

---

1. New Feature: Chat Action Buttons

Commits: 72abed8, 176db1e, cf8dc23, 85ea19b, 0222bdb, 87d8bb2, 1a01897, 938e6c3, e948c79, c56b166, c7eb50be
Files changed: MessageActionBar.ts (new), CreateFileModal.ts (new), MessageBubble.ts, ToolBubbleFactory.ts, MessageDisplay.ts, styles.css

What was added

A MessageActionBar component with four action buttons appears on every completed AI message:

Button	Action
Copy	Copies message text to clipboard
Insert	Inserts text at cursor position in the active note
Append	Appends text to the end of the active note
Create File	Opens a modal to save the message as a new note

The existing copy button that was embedded inside the message bubble header was removed and replaced by the Copy button in the action bar.

Placement and visual design

• The action buttons live inside the existing .message-actions-external pill in the message header top-right, next to the bot icon. No new container elements were added.
• The pill rests at 25% opacity and animates to full opacity on hover — a consistent affordance with the existing branch navigator pill.
• On mobile the resting opacity is 75%.
• Transition reduced from 0.2 s to 0.1 s to reduce repaint churn during text-selection drag operations.

Create File modal

• Default save folder: 00-Inbox
• Toggle "Open after create" is read via getValue() at create time (not from a cached class field) to ensure the user's choice is always respected.
• Folder picker, filename field, and open-after-save toggle.

Bugs found and fixed during implementation

Click-blocking (invisible pill intercepting mouse events)
The pill had opacity:0 but no pointer-events:none. It sat at z-index:20 above message content, silently swallowing all mouse clicks — text selection was broken for every message. Fixed by adding pointer-events:none to the hidden state and pointer-events:auto to all visible states.

Text not selectable
Obsidian's Electron shell applies user-select:none globally. Without an explicit override, message text could not be selected. Fixed by adding user-select:text; cursor:text to .message-content.

Insert/Append silently doing nothing
getActiveViewOfType(MarkdownView) returns null when the chat panel is the active workspace view — even if a note is open beside it. Fixed with a getMarkdownView() helper that falls back to getLeavesOfType('markdown') so the buttons work regardless of which panel last received focus. Also added editor.focus() before replaceSelection so the cursor becomes visible after insertion.

Insert/Append stealing editor focus
Clicking the buttons shifted focus from the active note to the chat panel button, causing getActiveViewOfType(MarkdownView) to return null on the very click that triggered the action. Fixed by calling event.preventDefault() on mousedown for Insert and Append, preserving editor focus through the click.

Copy returning wrong content on branched messages
When a user had retried a message, onCopyMessage read message.content directly — which always holds the most-recently-streamed response. Copying an earlier branch returned the latest branch's text instead. Fixed by reading through branchManager.getActiveMessageContent() so Copy always returns the currently displayed page.

---

2. Bug Fix: Chat Input Auto-Resize (BUG-01)

Commit: d6368d7
File: ChatInput.ts

Problem

The chat input box shrank unexpectedly while typing multi-line messages.

Root cause

The JavaScript auto-resize logic used minHeight/maxHeight values (48 px / 120 px) that did not match the CSS-defined values (72 px / 200 px). The height measurement also used a class-toggle approach that produced unreliable scrollHeight readings on contenteditable elements.

Fix

• minHeight corrected to 72 px (desktop) and 64 px (mobile) to match CSS.
• maxHeight corrected to 200 px (desktop) and 160 px (mobile) to match CSS.
• Height measurement now uses style.removeProperty() to temporarily remove the height constraint and read the natural scrollHeight, then restores it — the standard reliable pattern for contenteditable auto-resize.

---

3. Bug Fix: Tool Accordion Layout Thrashing (BUG-02)

Commit: 4aebd25
File: ProgressiveToolAccordion.ts

Problem

When an AI response included tool calls, the tool execution accordion re-formatted and shifted position on every status update, making it difficult to read while the tool was still running.

Root cause

refresh() called content.empty() and completely re-rendered all steps on every update — a full DOM teardown-and-rebuild on every streaming token.

Fix

Replaced full rebuild with targeted in-place DOM reconciliation:

• Existing step elements are updated in place (status class, text, meta, result).
• New steps are appended only when first seen.
• Reasoning items follow the same pattern.

This eliminates layout thrashing during active tool execution.

---

4. Bug Fix: Sticky Message Header for Long Responses (part of 8059edbc)

File: styles.css

Problem

On long AI responses, the action buttons (Copy, Insert, Append, Create File) scroll off-screen with the message header, making them inaccessible without scrolling back up.

Fix

The assistant message header is now position:sticky; top:0 within the scroll pane. The header — and its action buttons — remain visible at the top of the viewport as the user scrolls through a long message.

---

5. Bug Fix: Chat Header Title After Last Conversation Deleted (af70463f)

File: ChatView.ts

Problem

When the user deleted their last conversation, the welcome/empty state was shown correctly, but the header title continued to display the name of the deleted conversation instead of resetting to "Chat".

Fix

Added title reset to 'Chat' in both handleConversationsChanged() and loadInitialData() at the point where conversations.length === 0 triggers the welcome state.

---

6. Bug Fix: Beta Warning Banner Removed (607ec58)

Files: ChatLayoutBuilder.ts, styles.css

What changed

The experimental/beta warning banner that appeared at the top of the chat panel on every open was removed. Deleted: createWarningBanner(), its call site, and all associated CSS classes (.chat-experimental-warning, .chat-warning-banner-fadeout). Settings-tab warning styles were left untouched.

Rationale

The warning was more distracting than informative for a plugin in daily stable use.

---

7. Bug Fix: Context Bar Stale After Tab Switch (11f90913)

File: ChatView.ts

Problem

The context bar (showing the current note/file context) did not refresh when the user switched to a different tab and back. The displayed context could be stale.

Fix

Registered an active-leaf-change event listener so the context bar refreshes whenever the chat tab comes into focus.

---

8. Bug Fix: Conversation List — Rename Input & Cleanup Timer (F-01, dd65f6bb)

File: ConversationList.ts

Two fixes:

1. Timer leak on panel close: cleanup() now calls clearPendingDeleteConversation(), ensuring the 5-second "undo delete" confirmation timer is cancelled if the panel closes during the window.

2. DOM API consistency: showRenameInput() replaced two document.createElement calls with Obsidian's createEl API, consistent with the rest of the component.

---

9. Bug Fix: Branch Header Unnecessary Re-renders (F-02, 0b2c719f)

File: BranchHeader.ts

Problem

update() called render() unconditionally on hot iteration paths (e.g., streaming updates), causing unbounded registerDomEvent accumulation in the component's event registry.

Fix

Added a JSON equality check — render() is skipped if the context object is identical to the previous render's context.

---

10. Bug Fix: Loading Animation Interval Leak (F-03, 3c928fa1)

File: MessageBubble.ts

Problem

startLoadingAnimation() could be called twice during a streaming message (once on start, once on an update). The second call set a new interval without clearing the first, leaking the original interval for the remainder of the message.

Fix

startLoadingAnimation() now calls clearInterval(this.loadingInterval) before setting a new interval.

---

11. Bug Fix: Context Progress Bar API Idiom (F-05, 2a2a80fd)

File: ContextProgressBar.ts

Replaced direct className = '...' assignment with removeAttribute('class') + addClass(), consistent with Obsidian component conventions and avoiding accidental class clobbering.

---

12. Bug Fix: Conversation List Truncated at 50 (F-06, b436816c)

File: ConversationManager.ts

Problem

listConversations({ limit: 50 }) silently truncated users with more than 50 conversations — conversations existed in the database but were invisible in the UI.

Fix

Raised the limit from 50 to 500.

---

13. Bug Fix: Image Model Setting Not Saved (F-07, 9df51022)

File: ChatSettingsModal.ts

Problem

The per-chat settings modal has a section for selecting an image provider and model. On save, defaultImageModel was never written back to plugin settings — the selection was silently discarded on every close.

Fix

handleSave() now writes defaultImageModel to plugin.settings and calls saveSettings() after updating all other fields.

---

14. Bug Fix: Hardcoded OpenAI/GPT-4o Model Fallback (F-08, b9ef14c6)

File: ModelSelectionUtility.ts

Problem

When no configured default model existed, the utility returned { provider: 'openai', model: 'gpt-4o' }. For users who had not configured OpenAI (e.g., Anthropic-only or Ollama-only setups), this silently selected an unavailable model.

Fix

Returns an empty sentinel { provider: '', model: '' } instead. Callers already guard on truthiness, so no caller changes were needed.

---

15. Dead Code Removal (BUG-04 + F-04)

Commits: 7e26b3b, 295969cf
Files: ChatView.ts, MessageDisplay.ts, StreamingController.ts

• Removed dead isRetry variable from handleStreamingUpdate() in ChatView.ts. It was computed but never used — retry logic is fully handled by MessageAlternativeService.
• Removed never-called private escapeHtml() from MessageDisplay.ts.
• Removed never-called private escapeHtml() from StreamingController.ts.

---

16. CSS Cleanup (F-10, 49a6e711, 4e879636)

File: styles.css

Consolidated and removed orphaned CSS across the chat window:

Item	Change
E08-1	Consolidated duplicate .chat-settings-modal rules
E08-2	Renamed .chat-settings-button-container → .chat-settings-buttons to match TypeScript usage
E08-3	Deleted orphaned .chat-settings-section rule
E08-4	Deleted orphaned pre-refactor block: .workspace-info-section, .workspace-context-summary, .context-item, and children
E08-5	Deleted four orphaned context-notes-* / add-context-note-container rules (replaced by csr-notes-*)
E08-6	Added missing .csr-temp-value rule — used in ChatSettingsRenderer.ts but had no CSS definition; temperature span was unstyled
E08-7	Merged duplicate .llm-provider-model-row into single rule
Mobile	Merged two duplicate body.is-mobile .message-actions-external blocks; corrected stale comment
Copy animation	Added transform 0.1s ease to .message-action-btn transition so the copy-success scale(1.1) animates instead of snapping

---

Summary Table

#	Commit(s)	Category	User-visible impact
1	72abed8…c7eb50be	New feature	Copy, Insert, Append, Create File buttons on every AI message
2	d6368d7	Bug fix	Input box no longer shrinks while typing multi-line messages
3	4aebd25	Bug fix	Tool accordion no longer jumps/shifts during streaming
4	8059edbc (CSS only)	Enhancement	Action buttons stay visible while scrolling long messages
5	af70463f	Bug fix	Header title resets to "Chat" after last conversation deleted
6	607ec58	UX removal	Beta warning banner no longer shown on every chat open
7	11f90913	Bug fix	Context bar updates correctly when returning to chat tab
8	dd65f6bb	Bug fix	Rename inputs use correct API; delete timer cleaned up on close
9	0b2c719f	Performance	Branch header skips redundant re-renders
10	3c928fa1	Bug fix	Loading animation interval no longer leaks during streaming
11	2a2a80fd	Code quality	Context progress bar uses correct Obsidian API idiom
12	b436816c	Bug fix	All conversations visible (was silently capped at 50)
13	9df51022	Bug fix	Image model selection is now actually saved
14	b9ef14c6	Bug fix	No longer falls back to OpenAI/GPT-4o when not configured
15	7e26b3b, 295969cf	Dead code	Removed unused variables and methods
16	49a6e711, 4e879636	CSS	Orphaned rules removed; missing rule added; copy animation smoothed