fix(deps): resolve all open Dependabot alerts (#659-#680)#241
fix(deps): resolve all open Dependabot alerts (#659-#680)#241kherembourg wants to merge 1 commit into
Conversation
Bump direct deps and add yarn resolutions / npm overrides to patch 22
open Dependabot alerts across the monorepo and the two test-projects.
Root (yarn.lock):
- turbo ^2.9.14 in packages/{amazon,google,huawei,android-player}
(GHSA login callback CSRF #673-#676 + Yarn Berry detection RCE #669-#672 +
root yarn.lock #679-#680)
- resolutions added/bumped:
- @babel/plugin-transform-modules-systemjs >=7.29.4 (#667 high)
- basic-ftp >=5.3.1 (#659 high)
- fast-xml-builder >=1.1.7 (#660, #662 high+medium)
- ip-address >=10.1.1 (#665 medium)
test-projects/expo-purchasely-test (npm overrides):
- uuid >=11.1.1 (#678 medium)
- ws >=8.20.1 (#677 medium)
- fast-uri >=3.1.2 (#664, #666 high)
test-projects/rn-purchasely-test (npm overrides):
- @babel/plugin-transform-modules-systemjs >=7.29.4 (#668 high)
- fast-xml-builder >=1.1.7 (#661, #663 high+medium)
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
| Filename | Overview |
|---|---|
| package.json | Adds four new Yarn resolutions (@babel/plugin-transform-modules-systemjs, bumps basic-ftp, adds fast-xml-builder, ip-address) to address Dependabot alerts; no logic issues. |
| packages/amazon/package.json | Bumps turbo devDependency from ^1.10.7 to ^2.9.14, but the package's turbo.json still uses the v1 pipeline key (removed in Turbo v2), which will break build:android and build:ios tasks. |
| packages/android-player/package.json | Same turbo v1→v2 bump as amazon; same turbo.json pipeline compatibility issue applies. |
| packages/google/package.json | Same turbo v1→v2 bump; turbo.json pipeline key still present and incompatible with v2. |
| packages/huawei/package.json | Same turbo v1→v2 bump; turbo.json pipeline key still present and incompatible with v2. |
| test-projects/expo-purchasely-test/package.json | Adds npm overrides for fast-uri >=3.1.2, uuid >=11.1.1, and ws >=8.20.1 to address Dependabot alerts; straightforward security fix. |
| test-projects/rn-purchasely-test/package.json | Adds npm overrides for @babel/plugin-transform-modules-systemjs >=7.29.4 and fast-xml-builder >=1.1.7; straightforward security fix. |
| test-projects/expo-purchasely-test/package-lock.json | Lockfile regenerated: removes vulnerable ws 6.x sub-installs and old async-limiter, upgrades fast-uri to 3.1.2, adds uuid 14.0.0. |
| test-projects/rn-purchasely-test/package-lock.json | Lockfile regenerated: upgrades @babel/plugin-transform-modules-systemjs to 7.29.4, fast-xml-builder to 1.2.0, adds new transitive dep xml-naming. |
| yarn.lock | Root lockfile regenerated with Turbo 2.9.14 binaries added and all new resolution overrides resolved correctly. |
Flowchart
%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[Root package.json resolutions] -->|basic-ftp, babel, fast-xml-builder, ip-address| B[yarn.lock]
C[sub-packages amazon/google/huawei/android-player] -->|turbo v2.9.14| B
D[expo-purchasely-test overrides] -->|fast-uri, uuid, ws| E[expo package-lock.json]
F[rn-purchasely-test overrides] -->|babel, fast-xml-builder| G[rn package-lock.json]
C -->|turbo.json still uses pipeline key| H[Build broken in Turbo v2]
Prompt To Fix All With AI
Fix the following 1 code review issue. Work through them one at a time, proposing concise fixes.
---
### Issue 1 of 1
packages/amazon/package.json:56
**Turbo v2 `pipeline` key no longer recognized**
All four sub-packages (`amazon`, `android-player`, `google`, `huawei`) bump `turbo` from `^1.10.7` to `^2.9.14`, but their `turbo.json` files still use the v1 `pipeline` key, which was removed in Turbo 2.0 (renamed to `tasks`). Turbo v2 will silently ignore or error on the stale `pipeline` config, meaning `build:android` and `build:ios` tasks defined in those files won't execute as part of the pipeline. The same issue applies to `packages/android-player/turbo.json`, `packages/google/turbo.json`, and `packages/huawei/turbo.json`. Each of those files needs `"pipeline"` renamed to `"tasks"` to work with Turbo v2.
Reviews (1): Last reviewed commit: "fix(deps): resolve all open Dependabot a..." | Re-trigger Greptile
| "react-native": "0.79.2", | ||
| "react-native-builder-bob": "^0.36.0", | ||
| "turbo": "^1.10.7", | ||
| "turbo": "^2.9.14", |
There was a problem hiding this comment.
Turbo v2
pipeline key no longer recognized
All four sub-packages (amazon, android-player, google, huawei) bump turbo from ^1.10.7 to ^2.9.14, but their turbo.json files still use the v1 pipeline key, which was removed in Turbo 2.0 (renamed to tasks). Turbo v2 will silently ignore or error on the stale pipeline config, meaning build:android and build:ios tasks defined in those files won't execute as part of the pipeline. The same issue applies to packages/android-player/turbo.json, packages/google/turbo.json, and packages/huawei/turbo.json. Each of those files needs "pipeline" renamed to "tasks" to work with Turbo v2.
Prompt To Fix With AI
This is a comment left during a code review.
Path: packages/amazon/package.json
Line: 56
Comment:
**Turbo v2 `pipeline` key no longer recognized**
All four sub-packages (`amazon`, `android-player`, `google`, `huawei`) bump `turbo` from `^1.10.7` to `^2.9.14`, but their `turbo.json` files still use the v1 `pipeline` key, which was removed in Turbo 2.0 (renamed to `tasks`). Turbo v2 will silently ignore or error on the stale `pipeline` config, meaning `build:android` and `build:ios` tasks defined in those files won't execute as part of the pipeline. The same issue applies to `packages/android-player/turbo.json`, `packages/google/turbo.json`, and `packages/huawei/turbo.json`. Each of those files needs `"pipeline"` renamed to `"tasks"` to work with Turbo v2.
How can I resolve this? If you propose a fix, please make it concise.
Summary
Resolves all 22 currently open Dependabot alerts (#659 → #680) across the monorepo and both test-projects.
Changes
Root (yarn.lock)
turboto^2.9.14inpackages/{amazon,google,huawei,android-player}/package.json(closes #669–#676, #679–#680 — login callback CSRF + Yarn Berry detection RCE)resolutions:@babel/plugin-transform-modules-systemjs>=7.29.4(#667, high)basic-ftp>=5.3.1(#659, high)fast-xml-builder>=1.1.7(#660, #662)ip-address>=10.1.1(#665, medium)test-projects/expo-purchasely-test (npm overrides)
uuid>=11.1.1(#678, medium)ws>=8.20.1(#677, medium)fast-uri>=3.1.2(#664, #666, high)test-projects/rn-purchasely-test (npm overrides)
@babel/plugin-transform-modules-systemjs>=7.29.4(#668, high)fast-xml-builder>=1.1.7(#661, #663)Resolved versions (lockfiles)
Test plan
yarn installregeneratesyarn.lockcleanlynpm install --package-lock-onlyregenerates both test-projects lockfiles (0 vulnerabilities)yarn lint(0 errors)yarn typecheck(0 errors)yarn test— 4 suites, 139 tests pass🤖 Generated with Claude Code