Skip to content

fix(deps): resolve all open Dependabot alerts (#659-#680) #241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kherembourg wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(deps): resolve all open Dependabot alerts (#659-#680) #241

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,11 +27,14 @@
"resolutions": {
"@types/react": "^18.2.12",
"@types/react-native": "^0.70.14",
"basic-ftp": ">=5.2.2",
"@babel/plugin-transform-modules-systemjs": ">=7.29.4",
"basic-ftp": ">=5.3.1",
"brace-expansion": "~1.1.13",
"cacache/glob": "^10.5.0",
"fast-xml-builder": ">=1.1.7",
"flatted": ">=3.4.2",
"handlebars": ">=4.7.9",
"ip-address": ">=10.1.1",
"js-yaml": "^4.1.1",
"lodash": ">=4.18.0",
"lodash-es": ">=4.18.0",
Expand Down
2 changes: 1 addition & 1 deletion packages/amazon/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@
"react": "19.0.0",
"react-native": "0.79.2",
"react-native-builder-bob": "^0.36.0",
"turbo": "^1.10.7",
"turbo": "^2.9.14",
Copy link
Copy Markdown

@greptile-apps greptile-apps Bot May 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Turbo v2 pipeline key no longer recognized

All four sub-packages (amazon, android-player, google, huawei) bump turbo from ^1.10.7 to ^2.9.14, but their turbo.json files still use the v1 pipeline key, which was removed in Turbo 2.0 (renamed to tasks). Turbo v2 will silently ignore or error on the stale pipeline config, meaning build:android and build:ios tasks defined in those files won't execute as part of the pipeline. The same issue applies to packages/android-player/turbo.json, packages/google/turbo.json, and packages/huawei/turbo.json. Each of those files needs "pipeline" renamed to "tasks" to work with Turbo v2.

Prompt To Fix With AI 
This is a comment left during a code review.
Path: packages/amazon/package.json
Line: 56

Comment:
**Turbo v2 `pipeline` key no longer recognized**

All four sub-packages (`amazon`, `android-player`, `google`, `huawei`) bump `turbo` from `^1.10.7` to `^2.9.14`, but their `turbo.json` files still use the v1 `pipeline` key, which was removed in Turbo 2.0 (renamed to `tasks`). Turbo v2 will silently ignore or error on the stale `pipeline` config, meaning `build:android` and `build:ios` tasks defined in those files won't execute as part of the pipeline. The same issue applies to `packages/android-player/turbo.json`, `packages/google/turbo.json`, and `packages/huawei/turbo.json`. Each of those files needs `"pipeline"` renamed to `"tasks"` to work with Turbo v2.

How can I resolve this? If you propose a fix, please make it concise.

Fix in Claude Code Fix in Cursor Fix in Codex

"typescript": "^5.2.2"
},
"resolutions": {
Expand Down
2 changes: 1 addition & 1 deletion packages/android-player/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@
"react": "19.0.0",
"react-native": "0.79.2",
"react-native-builder-bob": "^0.36.0",
"turbo": "^1.10.7",
"turbo": "^2.9.14",
"typescript": "^5.2.2"
},
"resolutions": {
Expand Down
2 changes: 1 addition & 1 deletion packages/google/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@
"react": "19.0.0",
"react-native": "0.79.2",
"react-native-builder-bob": "^0.36.0",
"turbo": "^1.10.7",
"turbo": "^2.9.14",
"typescript": "^5.2.2"
},
"resolutions": {
Expand Down
2 changes: 1 addition & 1 deletion packages/huawei/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@
"react": "19.0.0",
"react-native": "0.79.2",
"react-native-builder-bob": "^0.36.0",
"turbo": "^1.10.7",
"turbo": "^2.9.14",
"typescript": "^5.2.2"
},
"resolutions": {
Expand Down
83 changes: 21 additions & 62 deletions test-projects/expo-purchasely-test/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions test-projects/expo-purchasely-test/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,13 +27,16 @@
"@isaacs/brace-expansion": ">=5.0.1",
"@xmldom/xmldom": ">=0.9.10",
"brace-expansion": "~1.1.13",
"fast-uri": ">=3.1.2",
"fast-xml-parser": ">=5.7.0",
"flatted": ">=3.3.4",
"minimatch": ">=3.1.3",
"node-forge": ">=1.4.0",
"postcss": ">=8.5.10",
"tar": ">=7.5.10",
"undici": ">=6.24.0",
"uuid": ">=11.1.1",
"ws": ">=8.20.1",
"yaml": ">=2.8.3"
}
}
31 changes: 24 additions & 7 deletions test-projects/rn-purchasely-test/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions test-projects/rn-purchasely-test/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,9 @@
"node": ">=18"
},
"overrides": {
"@babel/plugin-transform-modules-systemjs": ">=7.29.4",
"brace-expansion": "~1.1.13",
"fast-xml-builder": ">=1.1.7",
"fast-xml-parser": ">=5.7.0",
"flatted": ">=3.3.4",
"lodash": ">=4.18.0",
Expand Down
Loading
Loading