uls-fetch: correctly download weekly zip files#2
Open
molo1134 wants to merge 1 commit intoQueuingKoala:masterfrom
Open
uls-fetch: correctly download weekly zip files#2molo1134 wants to merge 1 commit intoQueuingKoala:masterfrom
molo1134 wants to merge 1 commit intoQueuingKoala:masterfrom
Conversation
QueuingKoala
requested changes
Nov 24, 2021
Owner
QueuingKoala
left a comment
QueuingKoala
left a comment
There was a problem hiding this comment.
With a small tweak, this looks good; see inline comments.
|
|
||
| al_type="${fn#*_}" | ||
| al_type="${al_type%%_*}" | ||
| al_type="${al_type%%.info}" |
Owner
There was a problem hiding this comment.
Nice catch on the suffix removal.
Could this be changed to either shortest-trailing, %.info or longest-trailing %%.* instead? A non-glob string won't benefit from longest-match. Between the above options, a glob makes it easier for alternative suffixes to be used in the future (like .info.txt) but may impair meaning as this is already hard-coded elsewhere. Either works for me as more direct, though.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.