Skip to content

uls-fetch: correctly download weekly zip files #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
molo1134 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

uls-fetch: correctly download weekly zip files #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions uls-fetch.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,6 +133,7 @@ main() {

al_type="${fn#*_}"
al_type="${al_type%%_*}"
al_type="${al_type%%.info}"
Copy link
Copy Markdown
Owner

@QueuingKoala QueuingKoala Nov 24, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch on the suffix removal.

Could this be changed to either shortest-trailing, %.info or longest-trailing %%.* instead? A non-glob string won't benefit from longest-match. Between the above options, a glob makes it easier for alternative suffixes to be used in the future (like .info.txt) but may impair meaning as this is already hard-coded elsewhere. Either works for me as more direct, though.

kind="${fn%%_*}"
if [ "$kind" = "weekly" ]; then
args="$args -W $al_type"
Expand Down