Skip to content

fix: show job plugin configs by instance#75

Merged
aledefra merged 1 commit intodevelopfrom
codex/job-plugins-by-instance
Mar 11, 2026
Merged

fix: show job plugin configs by instance#75
aledefra merged 1 commit intodevelopfrom
codex/job-plugins-by-instance

Conversation

@aledefra
Copy link
Collaborator

Summary

  • update Job Details plugin selector to list plugin configs by instance instead of deduplicating by signature
  • use a unique select key built from signature + instance so multiple CONTAINER_APP_RUNNER entries are selectable
  • keep all existing config rendering behavior unchanged

Verification

  • npm run lint

Copilot AI review requested due to automatic review settings March 11, 2026 10:41
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Job Details “Plugins” selector to show plugin configurations by plugin instance (rather than deduplicating by signature), allowing multiple configs for the same plugin signature to be selected independently.

Changes:

  • Adds a composite selector key derived from signature + instance.
  • Updates the select’s selectedKeys / lookup logic to use the composite key.
  • Changes plugin config list deduping/sorting to be instance-based.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@aledefra aledefra merged commit 1cf4e55 into develop Mar 11, 2026
7 checks passed
@aledefra aledefra deleted the codex/job-plugins-by-instance branch March 11, 2026 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants