Skip to content

fix: show job plugin configs by instance #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aledefra merged 1 commit into from
Mar 11, 2026
Merged

fix: show job plugin configs by instance #75

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 10 additions & 6 deletions src/components/job/config/JobPluginsSection.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@ import ConfigSectionTitle from './ConfigSectionTitle';
import ConfigWAR from './ConfigWAR';

type PluginConfig = {
key: string;
instance: string;
signature: string;
value: JobConfig;
};
Expand All @@ -26,12 +28,14 @@ export default function JobPluginsSection({ job }: { job: RunningJobWithResource
.flatten()
.map((plugin) => {
return {
key: `${plugin.signature}:${plugin.instance}`,
instance: plugin.instance,
signature: plugin.signature,
value: plugin.instance_conf,
};
})
.uniqBy('signature')
.sortBy('signature')
.uniqBy('instance')
.sortBy(['instance', 'signature'])
.value();

const [pluginConfig, setPluginConfig] = useState<PluginConfig>(pluginConfigs[0]!);
Expand All @@ -51,17 +55,17 @@ export default function JobPluginsSection({ job }: { job: RunningJobWithResource
{job.resources.jobType !== JobType.Service && (
<div className="w-[240px]">
<StyledSelect
selectedKeys={[pluginConfig.signature]}
selectedKeys={[pluginConfig.key]}
onSelectionChange={(keys) => {
const selectedKey = Array.from(keys)[0] as string;
setPluginConfig(pluginConfigs.find((config) => config.signature === selectedKey)!);
setPluginConfig(pluginConfigs.find((config) => config.key === selectedKey)!);
}}
placeholder="Select a plugin"
>
{pluginConfigs.map((item) => (
<SelectItem key={item.signature} textValue={item.signature}>
<SelectItem key={item.key} textValue={item.instance}>
<div className="row gap-2 py-1">
<div className="font-medium">{item.signature}</div>
<div className="font-medium">{item.instance}</div>
</div>
</SelectItem>
))}
Expand Down
Loading