[Galaxy Store]: Upgrade Samsung IAP SDK to version 6.5.2 + use Maven distribution#3492
Open
fire-at-will wants to merge 9 commits into
Open
[Galaxy Store]: Upgrade Samsung IAP SDK to version 6.5.2 + use Maven distribution#3492fire-at-will wants to merge 9 commits into
fire-at-will wants to merge 9 commits into
Conversation
fire-at-will
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3492 +/- ##
=======================================
Coverage 79.89% 79.89%
=======================================
Files 369 369
Lines 14871 14871
Branches 2048 2048
=======================================
Hits 11881 11881
Misses 2157 2157
Partials 833 833 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
MarkVillacampa
approved these changes
May 18, 2026
tonidero
reviewed
May 18, 2026
| testImplementation(libs.bundles.test) | ||
| testImplementation(libs.kotlin.test) | ||
| testImplementation("com.samsung.iap:samsung-iap:$samsungIapVersion@aar") | ||
| testImplementation(libs.samsung.iap) |
Contributor
There was a problem hiding this comment.
Hmm do we still need this one? I think it's not needed now that we use implementation
Contributor
Author
There was a problem hiding this comment.
Removed in 74687f9!
I also totally meant to mark this as "ready for review", it is now!
tonidero
reviewed
May 18, 2026
Contributor
tonidero
left a comment
tonidero
left a comment
There was a problem hiding this comment.
Niiice! Changes make sense to me! Will hold approval until this is ready for review :)
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
JayShortway
approved these changes
May 19, 2026
|
|
||
| assertJ = { module = "org.assertj:assertj-core", version.ref = "assertJ" } | ||
| amazon-appstore-sdk = { module = "com.amazon.device:amazon-appstore-sdk", version.ref = "amazon" } | ||
| samsung-iap = { module = "com.samsung.developer:iap", version.ref = "samsungIap" } |
tonidero
approved these changes
May 20, 2026
Contributor
tonidero
left a comment
tonidero
left a comment
There was a problem hiding this comment.
🚢 So nice to clean this up!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updates Galaxy Store support to use Samsung IAP from Maven Central now that Samsung distributes IAP SDK 6.5.2 publicly.
Now, developers will get the Samsung Galaxy IAP SDK transitively included in their app when they include the
purchases-store-galaxymodule.6.5.2com.samsung.developer:iapto the version catalog:feature:galaxydepend on Samsung IAP viaimplementation(libs.samsung.iap):feature:galaxyunconditionally in the repo's build, matching the Amazon feature module modeltest-galaxyCI jobSAMSUNG_IAP_MAVEN_URLflatDirrepositorylibs/samsung-iap-*.aarchecksGalaxyConfigurationdirectly instead of reflectionTesting
Manually tested through the purchase tester app
Follow Ups
test-galaxyCI jobNote
Medium Risk
Medium risk because it changes how the Samsung IAP dependency is resolved (from conditional/local AAR + CI download to Maven) and makes the Galaxy module always included, which can affect build/packaging and downstream dependency resolution.
Overview
Galaxy Store builds now consume Samsung IAP from Maven (v6.5.2) via a new version-catalog entry and
implementation(libs.samsung.iap)in:feature:galaxy, replacing the priorcompileOnly/local-AAR approach.This removes all conditional Galaxy enablement:
:feature:galaxyis always included insettings.gradle.kts, always added to the BOM andapi-tester, and always depended on by the purchase tester; CI jobs also drop thedownloadSamsungIapAarstep and the root Gradle task/env-var plumbing for fetching/copying the AAR.The purchase tester’s Galaxy configuration is simplified to use
GalaxyConfiguration.Builder(..., GalaxyBillingMode.TEST)directly (no reflection/availability checks), and the Galaxy warning string is updated accordingly.Reviewed by Cursor Bugbot for commit 80db9dc. Bugbot is set up for automated code reviews on this repo. Configure here.