[Enhancement] Dockerfile cleanup#226
Closed
amarburg wants to merge 1 commit intoRobotic-Decision-Making-Lab:mainfrom
Closed
[Enhancement] Dockerfile cleanup#226amarburg wants to merge 1 commit intoRobotic-Decision-Making-Lab:mainfrom
amarburg wants to merge 1 commit intoRobotic-Decision-Making-Lab:mainfrom
Conversation
amarburg
force-pushed
the
feature/rosdep_all_repos
branch
from
b5fdb27 to
f99ca99
Compare
- In the "ci" image:
- Move the apt-get above the "copy" so changes to this repo don't break that cache
- Only copy the */package.xml (requires recent "copy --parent" syntax) and blue.repos
- vcs import blue.repos so we rosdep dependencies for those packages as well.
- In the "robot" image:
- Move the gstreamer apt-get above the "copy" so it's cached
- Sort lists of packages for apt-get (https://docs.docker.com/build/building/best-practices/#sort-multi-line-arguments)
amarburg
force-pushed
the
feature/rosdep_all_repos
branch
from
f99ca99 to
8af46fe
Compare
evan-palmer
requested changes
Aug 8, 2024
Member
evan-palmer
left a comment
evan-palmer
left a comment
There was a problem hiding this comment.
Thanks for submitting this! I just have a couple of small comments. I saw that this was a draft after adding some comments, so I'll hold off on future reviews until it's ready for review.
|
This pull request is in conflict. Could you fix it @amarburg? |
This was referenced Aug 16, 2024
Collaborator
Author
|
FYI this PR has become a bit gnarly due to upstream changes. May be a hard push or a new PR in the future. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes Made
An opinionated cleanup of the dockerfile. Includes:
In the "ci" image:
vcs import < blue.reposso we rosdep dependencies for those packages into the image as well.In the "robot" image:
Sort lists of packages for apt-get (https://docs.docker.com/build/building/best-practices/#sort-multi-line-arguments)
At present, this PR will not build due to other issues (#220 #223 ). As this is an optimization, deal with this once the other issues have been resolved.
Associated Issues
n/a
Testing
None yet.