fix(tauri): don't leak wry into CEF builds + don't gate updater manifest on android#1165
Merged
Merged
Conversation
tauri-plugin-devtools (default-features = wry) and the tauri-plugin-notifications fork (tauri defaults = wry) both forced tauri/wry -> tauri-runtime-wry -> webkit2gtk into CEF builds that should only use the CEF runtime. - devtools: default-features = false; Sable's wry feature already enables tauri/wry for wry builds - notifications: bump to fork rev 0ca647a which drops tauri defaults - remove the broken not(feature = "cef") target-cfg gate (cargo ignores feature = in cfg predicates) and the redundant direct webkit2gtk dep (pulled transitively via tauri-runtime-wry)
The updater-manifest job needed [setup-release, build, android], but android takes 45 min and dev pushes cancel in-progress runs. So the manifest almost never ran -- latest.json was stuck at nightly.29.1 for 4 builds. The manifest only uses desktop .sig files (produced by the build job); android produces no updater artifacts. Drop it from needs.
lib.rs uses webkit2gtk directly for WebKitGTK permission handling. The transitive dep via tauri-runtime-wry doesn't put it in scope for 'use webkit2gtk::...'. Make it optional and gate via the wry feature so CEF builds still exclude it.
Record webkit2gtk as a direct (optional) dependency of the sable app crate in Cargo.lock, matching the Cargo.toml change that made webkit2gtk optional and gated via the wry feature. cargo --locked was failing because the lockfile was missing this dependency entry.
Member
|
Use the PR template please, also those links are linking to sable issues so no clue what this depends on |
7w1
enabled auto-merge
July 21, 2026 16:25
7w1
approved these changes
Jul 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
fix packaging to not including wry in cef build + don't wait 45 minutes to release the desktop auto update json
Fixes #
Type of change
Checklist:
AI disclosure: