Skip to content

fix(tauri): don't leak wry into CEF builds + don't gate updater manifest on android #1165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
7w1 merged 5 commits into from
Jul 21, 2026
Merged

fix(tauri): don't leak wry into CEF builds + don't gate updater manifest on android #1165

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5a9934a
fix(tauri): don't leak wry into CEF builds via plugins
eleboucher Jul 20, 2026
45d08e4
fix(ci): don't gate updater manifest on android build
eleboucher Jul 20, 2026
1055e3e
fix: re-add webkit2gtk as optional dep gated by wry feature
eleboucher Jul 20, 2026
01a7692
fix: sync Cargo.lock for optional webkit2gtk dep
eleboucher Jul 20, 2026
1f0593c
Delete .changeset/fix-cef-wry-leak.md
7w1 Jul 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/tauri-build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -457,7 +457,7 @@ jobs:

updater-manifest:
name: Publish updater manifest
needs: [setup-release, build, android]
needs: [setup-release, build]
runs-on: ubuntu-latest
timeout-minutes: 10
permissions:
Expand Down
2 changes: 1 addition & 1 deletion src-tauri/Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

21 changes: 12 additions & 9 deletions src-tauri/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,11 @@ tauri-plugin-clipboard-manager = "2.3.2"

# Debug-only in practice: only initialized under #[cfg(debug_assertions)] in
# lib.rs, so the release build never calls into it.
tauri-plugin-devtools = "2.0.0"
# default-features = false drops the plugin's `wry` feature (which enables
# `tauri/wry`); Sable's own `wry` feature already enables `tauri/wry` for wry
# builds, and CEF builds (--no-default-features --features cef) must not pull
# wry/tauri-runtime-wry/webkit2gtk.
tauri-plugin-devtools = { version = "2.0.0", default-features = false }

[target.'cfg(target_os = "windows")'.dependencies]
enigo = "0.5.0"
Expand All @@ -67,12 +71,12 @@ windows = { version = "0.61", features = [
tauri-plugin-single-instance = { version = "2.4.3", features = ["deep-link"] }

[target.'cfg(any(windows, target_os = "linux"))'.dependencies]
tauri-plugin-notifications = { git = "https://github.com/SableClient/tauri-plugin-notifications.git", rev = "4ea297bdeffaba6a8e2e4386a18fbd4dd59fa0f0" }
tauri-plugin-notifications = { git = "https://github.com/SableClient/tauri-plugin-notifications.git", rev = "0ca647a8d762cbba2ecfbefed7ff13565ec46229" }

# default-features = false drops notify-rust so macOS uses the native
# UNUserNotificationCenter backend (needs a signed .app to deliver).
[target.'cfg(target_os = "macos")'.dependencies]
tauri-plugin-notifications = { git = "https://github.com/SableClient/tauri-plugin-notifications.git", rev = "4ea297bdeffaba6a8e2e4386a18fbd4dd59fa0f0", default-features = false }
tauri-plugin-notifications = { git = "https://github.com/SableClient/tauri-plugin-notifications.git", rev = "0ca647a8d762cbba2ecfbefed7ff13565ec46229", default-features = false }

[target.'cfg(not(any(target_os = "android", target_os = "ios")))'.dependencies]
tauri-plugin-updater = { version = "2", optional = true }
Expand All @@ -82,10 +86,9 @@ tauri-plugin-window-state = "2.4.1"

[target.'cfg(any(target_os = "linux", target_os = "dragonfly", target_os = "freebsd", target_os = "openbsd", target_os = "netbsd"))'.dependencies]
gtk = "0.18"

# WebKitGTK is the wry runtime; not needed under CEF.
[target.'cfg(all(any(target_os = "linux", target_os = "dragonfly", target_os = "freebsd", target_os = "openbsd", target_os = "netbsd"), not(feature = "cef")))'.dependencies]
webkit2gtk = "2.0"
# Used directly in lib.rs for WebKitGTK permission handling (wry only).
# Optional + gated via the `wry` feature so CEF builds don't pull it.
webkit2gtk = { version = "2.0", optional = true }

# CEF (Chromium) runtime — Linux only; other platforms use wry.
# Repackage of tauri's unreleased feat/cef branch. Switch to the official
Expand All @@ -96,7 +99,7 @@ cef = { version = "=148.0.0", optional = true }
libloading = "0.8"

[target.'cfg(any(target_os = "android", target_os = "ios"))'.dependencies]
tauri-plugin-notifications = { git = "https://github.com/SableClient/tauri-plugin-notifications.git", rev = "4ea297bdeffaba6a8e2e4386a18fbd4dd59fa0f0", features = [
tauri-plugin-notifications = { git = "https://github.com/SableClient/tauri-plugin-notifications.git", rev = "0ca647a8d762cbba2ecfbefed7ff13565ec46229", features = [
"push-notifications",
] }
tauri-plugin-edge-to-edge = { git = "https://github.com/SableClient/tauri-plugin-edge-to-edge.git", rev = "33c6116c27be28c06df5a9d02231ecc5fdeb93c5" }
Expand All @@ -111,7 +114,7 @@ jni = "0.21"
[features]
default = ["wry", "updater"]
custom-protocol = ["tauri/custom-protocol"]
wry = ["tauri/wry"]
wry = ["tauri/wry", "dep:webkit2gtk"]
# Tauri auto-updater. Disable with --no-default-features --features wry,cef.
updater = ["dep:tauri-plugin-updater"]
# CEF (Chromium) runtime. Build with --no-default-features --features cef.
Expand Down
Loading