Use SciMLTesting v1.2 (folder-based run_tests)#54
Merged
ChrisRackauckas merged 1 commit intoJun 14, 2026
Conversation
Replace the hand-written GROUP dispatcher in test/runtests.jl with the SciMLTesting v1.2 folder-discovery run_tests harness. The Core testsets are split into self-contained top-level files (fast_log2_tests.jl, fast_pow_tests.jl, other_ad_engines_tests.jl) and the Enzyme group moves to test/Enzyme/ (enzyme_forward_tests.jl, enzyme_reverse_tests.jl), run in the main test env to match the pre-conversion behavior. QA stays in test/qa/ with its env. Adds SciMLTesting + SafeTestsets to the root and qa test deps and drops Pkg (the harness owns Pkg ops). test_groups.toml is unchanged; GROUP=All still runs Core + Enzyme (QA excluded), matching the old dispatcher. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
ChrisRackauckas-Claude
force-pushed
the
sciml-testing-rollout
branch
from
3a2d65f to
f68e318
Compare
ChrisRackauckas-Claude
changed the title
ChrisRackauckas
added a commit
that referenced
this pull request
Jun 25, 2026
Convert the hand-rolled `test/qa/qa.jl` (direct `Aqua.test_all` +
`JET.test_package`) onto the SciMLTesting v1.6 `run_qa` form and enable
the ExplicitImports checks:
using SciMLTesting, FastPower, JET, Test
run_qa(FastPower; explicit_imports = true)
Aqua, JET, and all six ExplicitImports checks pass cleanly (FastPower has
no external `[deps]`, so EI is trivially clean — no ignore-lists, no broken
markers needed).
The previous `@test_broken` placeholder for the Aqua `deps_compat` extras
finding (#53) is dropped: that finding was the `Pkg` extra missing a compat
entry, and `Pkg` was already removed from the root `[extras]`/test target in
#54. Verified against released SciMLTesting 1.6.0 that the full default
`Aqua.test_all(FastPower)` now passes the deps_compat (extras) sub-check, so
the marker was stale — issue #53 can be closed.
test/qa/Project.toml: bump SciMLTesting compat to "1.6"; drop the explicit
`check_extras = false` tweak (no longer needed). ExplicitImports stays a
transitive dep via SciMLTesting (not listed directly); Aqua kept as a direct
dep (its ambiguities sub-check child-procs), JET and SafeTestsets kept.
Verified locally (clean depot, released SciMLTesting 1.6.0, GROUP=QA via
run_tests folder-model): Quality Assurance 18/18 Pass, 0 Fail/Error/Broken.
Co-authored-by: ChrisRackauckas-Claude <accounts@chrisrackauckas.com>
Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Converts the test suite to the SciMLTesting v1.2
run_testsharness (folder-discovery model).test/runtests.jlbecomesusing SciMLTesting; run_tests().fast_log2_tests.jl,fast_pow_tests.jl,other_ad_engines_tests.jl), and the Enzyme group moves totest/Enzyme/(enzyme_forward_tests.jl,enzyme_reverse_tests.jl), run in the main test env — matching the pre-conversion dispatch.test/qa/with its sub-env.test/test_groups.tomlis unchanged;GROUP=Allstill runs Core + Enzyme (QA excluded), exactly as the old dispatcher.SciMLTesting+SafeTestsetsto the root andtest/qatest deps; dropsPkg(the harness owns all Pkg operations).Validated locally on Julia 1.11:
GROUP=Core(1200 + 5 + 4 tests) andGROUP=QA(11 pass + 1 expected@test_broken) both pass.Ignore until reviewed by @ChrisRackauckas.
🤖 Generated with Claude Code