Drop stale DiffRules 0.1 compatibility#4793
Conversation
|
Investigation log:
The branch contains only commit |
|
CI triage for
Thus the requested DiffRules minimum is green, and every inspected red ModelingToolkit lane is either a clean- |
|
Follow-up classification for the three downstream reds not listed above: both Catalyst Modeling lanes and the ModelingToolkitStandardLibrary Core lane were independently reproduced against current clean master during the later #4773 audit. The Catalyst baseline is 20 passed / 1 parent_sys error and is addressed by Catalyst #1511; the MTSL baseline is 15 passed / 1 AccelerationSensor structural-singularity error and is addressed by ModelingToolkitStandardLibrary #495. Full job links and evidence are recorded in #4773 (comment). This PR changes only the DiffRules compat entry, and its requested root downgrade lane passed, so no branch change is warranted. |
0bfc45a to
fa64c5c
Compare
|
Rebase validation for exact head
The branch remains a one-line |
Remove the stale pre-1.0 compatibility entry. Current Symbolics and NaNMath constraints already require DiffRules 1. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
fa64c5c to
bb9b3fd
Compare
|
Fresh validation for exact head
Ignore this PR until it has been reviewed by @ChrisRackauckas. |
|
Exact-head CI classification for
The compatibility change remains a one-line removal of unreachable DiffRules 0.1 support and the PR remains a draft for review. |
Summary
Investigation
The ModelingToolkitBase lower-bound graph could still select DiffRules 0.1 even though the package's current Symbolics and NaNMath constraints require the DiffRules 1 line. The branch changes only that compatibility entry.
Local verification
bb9b3fdcadonto current upstreammasteratf6c5c80da6.GROUP=InterfaceI: 1,475 passed and 3 pre-existing broken;Pkg.test()exited 0 in 44m12.6s.GROUP=InterfaceIwithPkg.test(; allow_reresolve=false): 1,495 passed and 5 pre-existing broken; exit 0 in 20m39.3s.d0c002a3661863d019bbb9107f7c795b00aa7561a0efd1272f3a018ae0c0e075before and after the test.git diff --checkpassed.lib/ModelingToolkitBase/src/systems/abstractsystem.jlpassed; that untouched current-masterfailure was reproduced, bisected, locally fixed, and opened separately as draft PR Fix Runic indentation in parse_variable #4801.Ignore this PR until it has been reviewed by @ChrisRackauckas.